Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC: implicit-{casts|dynamic} applies transitively :( #30810

Closed
matanlurey opened this issue Sep 20, 2017 · 5 comments
Closed

DDC: implicit-{casts|dynamic} applies transitively :( #30810

matanlurey opened this issue Sep 20, 2017 · 5 comments

Comments

@matanlurey
Copy link
Contributor

I thought there was a bug open, but I guess not or I missed it. Feel free to de-dupe.

Having the following configuration:

analyzer:
  strong-mode:
    implicit-casts: false
    implicit-dynamic: false

... tries to enforce this configuration transitively, i.e. to your dependencies, that might not be clean enough to use these. For a simple reproduction case, try depending on package:collection or package:path and add the above to your analysis_options.yaml.

@vsmenon
Copy link
Member

vsmenon commented Sep 20, 2017

Is this with pub or blaze?

@matanlurey
Copy link
Contributor Author

With pub (external), it seems to work fine in our Bazel environment.

/cc @jakemac53

@jakemac53
Copy link
Contributor

This should be fixed in the latest dev release, can you confirm?

@natebosch
Copy link
Member

dart-lang/pub#1684

@vsmenon
Copy link
Member

vsmenon commented Sep 20, 2017

Closing here. If there is an issue, can re-open the pub one.

@vsmenon vsmenon closed this as completed Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants