New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on class class. #31075

Closed
scheglov opened this Issue Oct 11, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@scheglov
Contributor

scheglov commented Oct 11, 2017

class class A {}
  @6: Expected a class body, but got 'class'.
  null
  #0      Listener.handleUnrecoverableError (package:front_end/src/fasta/parser/listener.dart:1156:5)
  #1      Parser.reportUnrecoverableErrorWithToken (package:front_end/src/fasta/parser/parser.dart:4761:23)
  #2      Parser.skipClassBody (package:front_end/src/fasta/parser/parser.dart:2760:14)
  #3      TopLevelParser.parseClassBody (package:front_end/src/fasta/parser/top_level_parser.dart:18:40)
  #4      Parser.parseClass (package:front_end/src/fasta/parser/parser.dart:1090:13)
  #5      Parser.parseClassOrNamedMixinApplication (package:front_end/src/fasta/parser/parser.dart:1062:14)
  #6      Parser.parseTopLevelKeywordDeclaration (package:front_end/src/fasta/parser/parser.dart:372:14)
  #7      Parser.parseTopLevelDeclarationImpl (package:front_end/src/fasta/parser/parser.dart:306:14)
  #8      Parser.parseUnit (package:front_end/src/fasta/parser/parser.dart:280:15)
  #9      computeUnlinkedUnit (package:front_end/src/incremental/unlinked_unit.dart:25:32)
  #10     FileState.refresh (package:front_end/src/incremental/file_state.dart:170:23)
  <asynchronous suspension>
  #11     FileSystemState.getFile (package:front_end/src/incremental/file_state.dart:383:18)
  <asynchronous suspension>
  #12     KernelDriver.getKernel.<anonymous closure>.<anonymous closure> (package:front_end/src/incremental/kernel_driver.dart:142:31)

@bwilkerson

@peter-ahe-google

This comment has been minimized.

Show comment
Hide comment
@peter-ahe-google

peter-ahe-google Oct 12, 2017

Contributor

This is a problem with DirectiveListener. We plan to replace it with deeper integration with Fasta's outline builder.

Contributor

peter-ahe-google commented Oct 12, 2017

This is a problem with DirectiveListener. We plan to replace it with deeper integration with Fasta's outline builder.

@peter-ahe-google peter-ahe-google removed their assignment Oct 12, 2017

@bwilkerson

This comment has been minimized.

Show comment
Hide comment
@bwilkerson

bwilkerson Dec 1, 2017

Member

@scheglov The parser has been changed. It now interprets the input above as two class declarations, with the first declaration being incomplete. I suspect that this issue has been fixed. Can you confirm?

Member

bwilkerson commented Dec 1, 2017

@scheglov The parser has been changed. It now interprets the input above as two class declarations, with the first declaration being incomplete. I suspect that this issue has been fixed. Can you confirm?

@scheglov scheglov closed this Dec 1, 2017

@scheglov

This comment has been minimized.

Show comment
Hide comment
@scheglov

scheglov Dec 1, 2017

Contributor

Thanks!

Contributor

scheglov commented Dec 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment