New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob pattern doesn't work correctly in the exclude section in analysis_options.yaml #31343

Closed
yyoon opened this Issue Nov 9, 2017 · 5 comments

Comments

Projects
None yet
7 participants
@yyoon
Contributor

yyoon commented Nov 9, 2017

When specifying exclude files in the analysis_options.yaml file, we've noticed that glob pattern doesn't work but specifying individual files works.

[This works]

analyzer:
  exclude:
    - 'testdata/directives_test/after.dart'
    - 'testdata/directives_test/before.dart'
    - 'testdata/double_quotes_test/after.dart'
    - 'testdata/double_quotes_test/before.dart'

[This doesn't work]

analyzer:
  exclude:
    - 'testdata/**'

This was happening in a fuchsia dart package, in case it matters.

cc: @pylaligand @zanderso @bwilkerson

@natebosch

This comment has been minimized.

Show comment
Hide comment
@natebosch

natebosch Nov 18, 2017

Member

I think this used to work, but I'm seeing the same problem.

Has there been a change in analyzer?

Member

natebosch commented Nov 18, 2017

I think this used to work, but I'm seeing the same problem.

Has there been a change in analyzer?

@pylaligand

This comment has been minimized.

Show comment
Hide comment
@pylaligand

pylaligand Nov 18, 2017

Contributor

The documentation suggests that it should work: https://www.dartlang.org/guides/language/analysis-options#excluding-files

Contributor

pylaligand commented Nov 18, 2017

The documentation suggests that it should work: https://www.dartlang.org/guides/language/analysis-options#excluding-files

@pylaligand

This comment has been minimized.

Show comment
Hide comment
@pylaligand

pylaligand Dec 14, 2017

Contributor

Could this get looked at?

/cc @bwilkerson

Contributor

pylaligand commented Dec 14, 2017

Could this get looked at?

/cc @bwilkerson

@apwilson

This comment has been minimized.

Show comment
Hide comment
@apwilson

apwilson Feb 6, 2018

Contributor

I ran into this issue yesterday.

Contributor

apwilson commented Feb 6, 2018

I ran into this issue yesterday.

@MichaelRFairhurst MichaelRFairhurst self-assigned this Feb 13, 2018

@MichaelRFairhurst

This comment has been minimized.

Show comment
Hide comment
@MichaelRFairhurst

MichaelRFairhurst Feb 13, 2018

Contributor

I reproed this just now...looks like there's a discrepancy between what the cli analyzer expects vs server. Server handles this correctly, and cli doesn't.

Will begin digging in further!

Contributor

MichaelRFairhurst commented Feb 13, 2018

I reproed this just now...looks like there's a discrepancy between what the cli analyzer expects vs server. Server handles this correctly, and cli doesn't.

Will begin digging in further!

@dart-bot dart-bot closed this in 748cfdf Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment