New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add more analysis options on top of an included one #31345

Closed
yyoon opened this Issue Nov 9, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@yyoon
Contributor

yyoon commented Nov 9, 2017

(related to #31343, #31344)

For one Dart package, we were trying to use a common analysis_options.yaml file and only add more exclusion patterns, but it didn't work as expected.

[This works]

analyzer:
  exclude:
    - 'testdata/directives_test/after.dart'
    - 'testdata/directives_test/before.dart'
    - 'testdata/double_quotes_test/after.dart'
    - 'testdata/double_quotes_test/before.dart'

[This doesn't work]

include: ../analysis_options.yaml
analyzer:
  exclude:
    - 'testdata/directives_test/after.dart'
    - 'testdata/directives_test/before.dart'
    - 'testdata/double_quotes_test/after.dart'
    - 'testdata/double_quotes_test/before.dart'

This was happening in a fuchsia dart package, in case it matters.

cc: @pylaligand @zanderso @bwilkerson

@MichaelRFairhurst

This comment has been minimized.

Show comment
Hide comment
@MichaelRFairhurst

MichaelRFairhurst Feb 13, 2018

Contributor

I reproed this just now...looks like there's a discrepancy between what the cli analyzer expects vs server. Server handles this correctly, and cli doesn't.

Will begin digging in further!

Contributor

MichaelRFairhurst commented Feb 13, 2018

I reproed this just now...looks like there's a discrepancy between what the cli analyzer expects vs server. Server handles this correctly, and cli doesn't.

Will begin digging in further!

@MichaelRFairhurst

This comment has been minimized.

Show comment
Hide comment
Contributor

MichaelRFairhurst commented Feb 14, 2018

dart-bot pushed a commit that referenced this issue Feb 14, 2018

Fix #31345 include analysis_options breaks some properties
Bug: 31345
Change-Id: I8d588cc49931ccb4699cc33c8e12a7f701a0a513
Reviewed-on: https://dart-review.googlesource.com/41500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment