New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide or split generating deps files from compile-platform #31358

Open
sigmundch opened this Issue Nov 10, 2017 · 3 comments

Comments

3 participants
@sigmundch
Member

sigmundch commented Nov 10, 2017

Background context: we are using compile-platfrom in bazel to build the platform files.

Bazel doesn't need the .deps file, so we don't need to generate it. We are currently running into trouble on the step that produces them. We could try to fix the issues (e.g. they relate to not passing the --packages option appropriately), but since we don't need the .deps file I would prefer to avoid that kind of fix.

My preference would be to split out the logic out of the compile-platform script, since it technically has nothing specific about compile-platform, but it would also work if we hide it behind a flag for now.

Other thoughts?

@keertip

This comment has been minimized.

Show comment
Hide comment
@keertip

keertip Nov 20, 2017

Contributor

fyi, this is blocking building the dill files in google3.

Contributor

keertip commented Nov 20, 2017

fyi, this is blocking building the dill files in google3.

@keertip keertip added the p1-high label Nov 20, 2017

@peter-ahe-google

This comment has been minimized.

Show comment
Hide comment
@peter-ahe-google

peter-ahe-google Nov 20, 2017

Contributor

I'd prefer to keep the feature in the compile-platform script as that makes it easier to use it conventional build systems. We can add an option to turn it on similarly to how GCC and other compilers work.

If this is indeed a P1 issue, please provide --packages as a short-term work around.

Contributor

peter-ahe-google commented Nov 20, 2017

I'd prefer to keep the feature in the compile-platform script as that makes it easier to use it conventional build systems. We can add an option to turn it on similarly to how GCC and other compilers work.

If this is indeed a P1 issue, please provide --packages as a short-term work around.

@sigmundch

This comment has been minimized.

Show comment
Hide comment
@sigmundch

sigmundch Dec 1, 2017

Member

Adjusted to P2 because we have temporary a workaround

Member

sigmundch commented Dec 1, 2017

Adjusted to P2 because we have temporary a workaround

@kmillikin kmillikin added this to Incoming in Dart Front End Jan 3, 2018

@jensjoha jensjoha moved this from Incoming Untriaged to Triaged in Dart Front End Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment