New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js: Multiple occurrences of corrupted test.js #31363

Closed
eernstg opened this Issue Nov 13, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@eernstg
Member

eernstg commented Nov 13, 2017

The test language/deferred_type_dependency_test fails on dart2js-win7-ie11ff-3-4-be, apparently because it generates a JavaScript file containing an illegal character:

FAILED: dart2js-firefox release_x64 language/deferred_type_dependency_test/as
Expected: Pass
Actual: RuntimeError
--- Command "dart2js" (took 01.000691s):
set DART_CONFIGURATION=ReleaseX64 & out\ReleaseX64\dart-sdk\bin\dart2js.bat --generate-code-with-compile-time-errors --test-mode --packages=E:\b\build\slave\ff_3-be\build\sdk\.packages --out=E:/b/build/slave/ff_3-be/build/sdk/out/ReleaseX64/generated_compilations/dart2js-sdk/multitest_language_deferred_type_dependency_test_as/test.js E:\b\build\slave\ff_3-be\build\sdk\out\ReleaseX64\generated_tests\language\deferred_type_dependency_test_as.dart
stdout:
Hint: When run on the command-line, the compiled output might require a preamble file located in:
  <sdk>/lib/_internal/js_runtime/lib/preambles.
Compiled 1,822,738 characters Dart to 254,358 characters JavaScript in 1.69 seconds
Dart file (E:\b\build\slave\ff_3-be\build\sdk\out\ReleaseX64\generated_tests\language\deferred_type_dependency_test_as.dart) compiled to JavaScript: out/ReleaseX64/generated_compilations/dart2js-sdk/multitest_language_deferred_type_dependency_test_as/test.js
--- Command "firefox" (took 42ms):
E:\b\build\slave\ff_3-be\build\sdk\tools\sdks\win\dart-sdk\bin\dart.exe tools/testing/dart/launch_browser.dart firefox http://127.0.0.1:63908/root_build/generated_tests/dart2js-firefox-sdk/multitest_language_deferred_type_dependency_test_as/test.html?crossOriginPort=63909
Runtime window.onerror:
window.onerror called: 
http://127.0.0.1:63908/root_build/generated_compilations/dart2js-sdk/multitest_language_deferred_type_dependency_test_as/test.js:2264:
SyntaxError: illegal character

Excerpt above taken from this log file.

@eernstg

This comment has been minimized.

Show comment
Hide comment
@eernstg

eernstg Nov 13, 2017

Member

A different test fails in a similar context: co19/LayoutTests/fast/files/file-reader-result-twice_t01 fails on dart2js-win7-ie11ff-4-4-be with an Unspecified error. Perhaps there is some underlying cause for data corruption that affects various JavaScript sources (all named test.js)? Here's the log excerpt:

FAILED: dart2js-ie11 release_x64 co19/LayoutTests/fast/files/file-reader-result-twice_t01
Expected: Pass
Actual: RuntimeError
--- Command "dart2js" (took 02.000574s):
set DART_CONFIGURATION=ReleaseX64 & out\ReleaseX64\dart-sdk\bin\dart2js.bat --generate-code-with-compile-time-errors --test-mode --fast-startup --packages=E:\b\build\slave\ff_4-be\build\sdk\.packages --out=E:/b/build/slave/ff_4-be/build/sdk/out/ReleaseX64/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js E:\b\build\slave\ff_4-be\build\sdk\tests\co19\src\LayoutTests\fast\files\file-reader-result-twice_t01.dart
stdout:
Compiled 3,848,233 characters Dart to 327,224 characters JavaScript in 2.57 seconds
Dart file (E:\b\build\slave\ff_4-be\build\sdk\tests\co19\src\LayoutTests\fast\files\file-reader-result-twice_t01.dart) compiled to JavaScript: out/ReleaseX64/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js
--- Command "ie11" (took 289ms):
E:\b\build\slave\ff_4-be\build\sdk\tools\sdks\win\dart-sdk\bin\dart.exe tools/testing/dart/launch_browser.dart ie11 http://127.0.0.1:64353/root_build/generated_tests/dart2js-ie11-sdk/short7576_s_file-reader-result-twice_t01/test.html?crossOriginPort=64354
Runtime window.onerror:
window.onerror called: 
http://127.0.0.1:64353/root_build/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js:3914:
Unspecified error.

Member

eernstg commented Nov 13, 2017

A different test fails in a similar context: co19/LayoutTests/fast/files/file-reader-result-twice_t01 fails on dart2js-win7-ie11ff-4-4-be with an Unspecified error. Perhaps there is some underlying cause for data corruption that affects various JavaScript sources (all named test.js)? Here's the log excerpt:

FAILED: dart2js-ie11 release_x64 co19/LayoutTests/fast/files/file-reader-result-twice_t01
Expected: Pass
Actual: RuntimeError
--- Command "dart2js" (took 02.000574s):
set DART_CONFIGURATION=ReleaseX64 & out\ReleaseX64\dart-sdk\bin\dart2js.bat --generate-code-with-compile-time-errors --test-mode --fast-startup --packages=E:\b\build\slave\ff_4-be\build\sdk\.packages --out=E:/b/build/slave/ff_4-be/build/sdk/out/ReleaseX64/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js E:\b\build\slave\ff_4-be\build\sdk\tests\co19\src\LayoutTests\fast\files\file-reader-result-twice_t01.dart
stdout:
Compiled 3,848,233 characters Dart to 327,224 characters JavaScript in 2.57 seconds
Dart file (E:\b\build\slave\ff_4-be\build\sdk\tests\co19\src\LayoutTests\fast\files\file-reader-result-twice_t01.dart) compiled to JavaScript: out/ReleaseX64/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js
--- Command "ie11" (took 289ms):
E:\b\build\slave\ff_4-be\build\sdk\tools\sdks\win\dart-sdk\bin\dart.exe tools/testing/dart/launch_browser.dart ie11 http://127.0.0.1:64353/root_build/generated_tests/dart2js-ie11-sdk/short7576_s_file-reader-result-twice_t01/test.html?crossOriginPort=64354
Runtime window.onerror:
window.onerror called: 
http://127.0.0.1:64353/root_build/generated_compilations/dart2js-sdk/short7577_s_file-reader-result-twice_t01/test.js:3914:
Unspecified error.

@eernstg eernstg changed the title from dart2js: Generates code containing illegal character to dart2js: Multiple occurrences of corrupted test.js Nov 13, 2017

@sigmundch

This comment has been minimized.

Show comment
Hide comment
@sigmundch

sigmundch Nov 13, 2017

Member

The first issue could be an issue in FF: we have seen in the past that FF had sometimes failed to load a deferred library, but we have not seen the reason why - we thought it could be because it was dropping connections, but one possibility is that it could because it truncates files and runs into syntax errors as a result? This needs further investigation, but it does appear to be more a FF issue than a dart2js issue.

Member

sigmundch commented Nov 13, 2017

The first issue could be an issue in FF: we have seen in the past that FF had sometimes failed to load a deferred library, but we have not seen the reason why - we thought it could be because it was dropping connections, but one possibility is that it could because it truncates files and runs into syntax errors as a result? This needs further investigation, but it does appear to be more a FF issue than a dart2js issue.

@eernstg

This comment has been minimized.

Show comment
Hide comment
@eernstg

eernstg Nov 14, 2017

Member

I added 'browser-firefox', but there doesn't seem to be an obviously better choice for 'area-...', so I left it at 'area-dart2js'.

Member

eernstg commented Nov 14, 2017

I added 'browser-firefox', but there doesn't seem to be an obviously better choice for 'area-...', so I left it at 'area-dart2js'.

@eernstg

This comment has been minimized.

Show comment
Hide comment
@eernstg

eernstg Nov 17, 2017

Member

Sigmund, I'm trying to follow Slava's good advice about ensuring that Gardening issues have an owner. I realize that this is a nasty intermittent Firefox specific problem, but I'm giving it to you now. Hope you can find a good place to put this responsibility if it needs to be re-seated. ;)

Member

eernstg commented Nov 17, 2017

Sigmund, I'm trying to follow Slava's good advice about ensuring that Gardening issues have an owner. I realize that this is a nasty intermittent Firefox specific problem, but I'm giving it to you now. Hope you can find a good place to put this responsibility if it needs to be re-seated. ;)

@sigmundch sigmundch closed this Jun 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment