New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have the analysis server benchmarks support a `--preview-dart-2` flag #31364

Closed
devoncarew opened this Issue Nov 13, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@devoncarew
Member

devoncarew commented Nov 13, 2017

This would enable the new CFE for the analysis server, and would allow us to do comparison benchmarks between the new and old front-ends.

@bwilkerson @scheglov @sortie

@devoncarew

This comment has been minimized.

Show comment
Hide comment
@devoncarew

devoncarew Nov 13, 2017

Member

For this, the analysis server would also need to support a --preview-dart-2 flag.

Member

devoncarew commented Nov 13, 2017

For this, the analysis server would also need to support a --preview-dart-2 flag.

@scheglov scheglov self-assigned this Nov 14, 2017

@scheglov

This comment has been minimized.

Show comment
Hide comment
Contributor

scheglov commented Nov 14, 2017

whesse pushed a commit that referenced this issue Nov 14, 2017

Issue 31364. Add support for --preview-dart-2 flag in Analysis Server.
You don't want to turn it on yet.

R=brianwilkerson@google.com, devoncarew@google.com

Bug: #31364
Change-Id: I37639181e500298d38beee6d9f91330c7465b14a
Reviewed-on: https://dart-review.googlesource.com/20640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@devoncarew

This comment has been minimized.

Show comment
Hide comment

@devoncarew devoncarew closed this Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment