New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nondeterministic results for front_end with test language_2/generic_constructor_mixin3_test #31368

Closed
stereotype441 opened this Issue Nov 14, 2017 · 1 comment

Comments

2 participants
@stereotype441
Member

stereotype441 commented Nov 14, 2017

I am working on a CL that performs type checking of invocation arguments in the front end, and I'm seeing strange results for the test language_2/generic_constructor_mixin3_test, depending how much of the test suite I run.

If I run python tools/test.py -m release -c dartk --strong language_2, then tests language_2/generic_constructor_mixin3_test/none and language_2/generic_constructor_mixin3_test/01 both pass.

If I run python tools/test.py -m release -c dartk --strong language_2/generic_constructor_mixin3_test, then test language_2/generic_constructor_mixin3_test/none gets a RuntimeError, and language_2/generic_constructor_mixin3_test/01 gets a CompileTimeError. I see similar results if I run python tools/test.py -m release -c dartk --strong language_2/generic_constructor_mixin3_test/none or python tools/test.py -m release -c dartk --strong language_2/generic_constructor_mixin3_test/01 directly.

For now I'm going to update the status file to allow both possible outcomes for each test.

@kmillikin kmillikin added this to Incoming in Dart Front End Jan 3, 2018

@jensjoha

This comment has been minimized.

Show comment
Hide comment
@jensjoha

jensjoha Jan 4, 2018

Contributor

This doesn't seem to be a front-end issue, but rather a test.py issue... I have a fix in flight nonetheless.

Contributor

jensjoha commented Jan 4, 2018

This doesn't seem to be a front-end issue, but rather a test.py issue... I have a fix in flight nonetheless.

@jensjoha jensjoha self-assigned this Jan 4, 2018

@jensjoha jensjoha moved this from Incoming Untriaged to In Progress in Dart Front End Jan 4, 2018

@whesse whesse closed this in 501cca4 Jan 5, 2018

@jensjoha jensjoha moved this from In Progress to Verify Fixed in Dart Front End Jan 5, 2018

@jensjoha jensjoha moved this from Verify Fixed to Done in Dart Front End Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment