New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart_bootstrap should not need kernel binaries when compiling AOT snapshots #31560

Closed
mraleph opened this Issue Dec 6, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@mraleph
Contributor

mraleph commented Dec 6, 2017

Currently we need to pass --kernel-binaries even when compiling the fully linked Kernel binary into an AOT snapshot.

We should not need to do that. This can also lead to incorrect code generated if we end up loading parts of the Isolate from one binary (e.g. vm_platform) and parts of the isolate from another binary (input kernel).

@mraleph mraleph added p1-high and removed p2-medium labels Dec 6, 2017

@mraleph mraleph added this to the 2.0-alpha milestone Dec 6, 2017

@alexmarkov

This comment has been minimized.

Show comment
Hide comment
@alexmarkov

alexmarkov Dec 12, 2017

Contributor

Commit 0352170 removes the requirement to specify --kernel-binaries option. If this option is not specified, then the kernel file from the command line is treated as fully linked and platform classes are used from that binary. '-c dartkp --strong' configuration of the test tool and pkg/vm/tool/precompiler2 run in this mode.

If --kernel-binaries is specified, platform libraries are still loaded from the vm_platform.

Contributor

alexmarkov commented Dec 12, 2017

Commit 0352170 removes the requirement to specify --kernel-binaries option. If this option is not specified, then the kernel file from the command line is treated as fully linked and platform classes are used from that binary. '-c dartkp --strong' configuration of the test tool and pkg/vm/tool/precompiler2 run in this mode.

If --kernel-binaries is specified, platform libraries are still loaded from the vm_platform.

@a-siva

This comment has been minimized.

Show comment
Hide comment
@a-siva

a-siva Feb 7, 2018

Contributor

We don't have the --kernel-binaries option anymore.

Contributor

a-siva commented Feb 7, 2018

We don't have the --kernel-binaries option anymore.

@a-siva a-siva closed this Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment