New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some custom element tests are failing when compiled using dartdevc #31568

Closed
munificent opened this Issue Dec 7, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@munificent
Member

munificent commented Dec 7, 2017

I don't know exactly what's going on, but I'm leaving a bug here mainly to reference it in the status file. Here's what I see:

  1. The test calls document.registerElement().
  2. That eventually calls _registerCustomElement() in the SDK.
  3. That calls _interceptors.findInterceptorConstructorForType(type) for the given class.
  4. That returns null.
  5. _registerCustomElement() throws an ArgumentError.
@matanlurey

This comment has been minimized.

Show comment
Hide comment
@matanlurey

matanlurey Dec 7, 2017

Contributor

FWIW, these aren't used. So I'd keep this priority pretty low (even post Dart 2 is fine)

Contributor

matanlurey commented Dec 7, 2017

FWIW, these aren't used. So I'd keep this priority pretty low (even post Dart 2 is fine)

@munificent

This comment has been minimized.

Show comment
Hide comment
@munificent

munificent Dec 7, 2017

Member

Yup, that's the plan. Filing the bug so I can forget about it and make it future-Bob's problem. :)

Member

munificent commented Dec 7, 2017

Yup, that's the plan. Filing the bug so I can forget about it and make it future-Bob's problem. :)

@jmesserly

This comment has been minimized.

Show comment
Hide comment
@jmesserly

jmesserly Apr 19, 2018

Member

I think this is covered by #27311

Member

jmesserly commented Apr 19, 2018

I think this is covered by #27311

@jmesserly jmesserly closed this Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment