New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to start testing ARM/ARM64 dartk and dartkp configurations #31573

Closed
mraleph opened this Issue Dec 7, 2017 · 12 comments

Comments

Projects
None yet
6 participants
@mraleph
Contributor

mraleph commented Dec 7, 2017

We need to ensure coverage for this configurations as they are the ones that we are going to be shipping.

@athomas do we have free buildbot slaves that can be used for this? If we do I can update recipes myself, just let me know. Otherwise please see if we can get slaves from somewhere.

@mraleph mraleph added this to the 2.0-alpha milestone Dec 7, 2017

@mraleph

This comment has been minimized.

Show comment
Hide comment
@mraleph
Contributor

mraleph commented Dec 7, 2017

@whesse

This comment has been minimized.

Show comment
Hide comment
@whesse

whesse Dec 7, 2017

Member

We can ask for more arm64 slaves, but there are currently no arm slaves on buildbot. We are discussing how to solve this problem. We can use the existing arm64 slaves for multiple builders while waiting for more.

Member

whesse commented Dec 7, 2017

We can ask for more arm64 slaves, but there are currently no arm slaves on buildbot. We are discussing how to solve this problem. We can use the existing arm64 slaves for multiple builders while waiting for more.

@mraleph

This comment has been minimized.

Show comment
Hide comment
@mraleph

mraleph Dec 7, 2017

Contributor

Intel slaves are fine too - we can at least start testing SIMARM/SIMARM64.

Contributor

mraleph commented Dec 7, 2017

Intel slaves are fine too - we can at least start testing SIMARM/SIMARM64.

@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Dec 8, 2017

Member

Could we do this on LUCI? I don't see any reason why we couldn't.

We need ARM bots there as well.
We already have Intel bots.
We probably don't need any recipe changes, only update the test matrix and I can do the necessary setup in LUCI if we need a new builder there.

What will be the build.py and test.py commands we want to run?

Member

athomas commented Dec 8, 2017

Could we do this on LUCI? I don't see any reason why we couldn't.

We need ARM bots there as well.
We already have Intel bots.
We probably don't need any recipe changes, only update the test matrix and I can do the necessary setup in LUCI if we need a new builder there.

What will be the build.py and test.py commands we want to run?

@mraleph

This comment has been minimized.

Show comment
Hide comment
@mraleph

mraleph Dec 8, 2017

Contributor

@athomas

I think this would be a good start:

# DartK
tools/build.py -m release -a simarm,simarm64 runtime_kernel
tools/test.py -m release -c dartk -a simarm,simarm64
tools/test.py -m release -c dartk -a simarm,simarm64 --strong  language_2 corelib_2 lib_2 standalone_2

# DartKP
tools/build.py -m release -a simarm,simarm64 runtime_kernel dart_precompiled_runtime
tools/test.py -m release -c dartkp -r dart_precompiled -a simarm,simarm64
tools/test.py -m release -c dartkp  -r dart_precompiled -a simarm,simarm64 --strong  language_2 corelib_2 lib_2 standalone_2
Contributor

mraleph commented Dec 8, 2017

@athomas

I think this would be a good start:

# DartK
tools/build.py -m release -a simarm,simarm64 runtime_kernel
tools/test.py -m release -c dartk -a simarm,simarm64
tools/test.py -m release -c dartk -a simarm,simarm64 --strong  language_2 corelib_2 lib_2 standalone_2

# DartKP
tools/build.py -m release -a simarm,simarm64 runtime_kernel dart_precompiled_runtime
tools/test.py -m release -c dartkp -r dart_precompiled -a simarm,simarm64
tools/test.py -m release -c dartkp  -r dart_precompiled -a simarm,simarm64 --strong  language_2 corelib_2 lib_2 standalone_2
@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Dec 8, 2017

Member

Is there some plan to make these tests faster somehow? Or alternatively, can we run a smaller suite than what was suggested?
I have tried running "tools/test.py -m release -c dartk -a simarm" and that takes ~2 hours to reach 15%. For reference, buildbot runs "test.py -mrelease '--arch=simarm'" in ~30 minutes (100% of twice as many tests).

Member

athomas commented Dec 8, 2017

Is there some plan to make these tests faster somehow? Or alternatively, can we run a smaller suite than what was suggested?
I have tried running "tools/test.py -m release -c dartk -a simarm" and that takes ~2 hours to reach 15%. For reference, buildbot runs "test.py -mrelease '--arch=simarm'" in ~30 minutes (100% of twice as many tests).

@mraleph

This comment has been minimized.

Show comment
Hide comment
@mraleph

mraleph Dec 8, 2017

Contributor

Yes, we are going to switch dartk configuration to use batch mode Fasta compiler instead of --dfe= isolate.

I have filed an issue for this: #31585, once we land that we can move on with landing buildbot configuration.

Contributor

mraleph commented Dec 8, 2017

Yes, we are going to switch dartk configuration to use batch mode Fasta compiler instead of --dfe= isolate.

I have filed an issue for this: #31585, once we land that we can move on with landing buildbot configuration.

@mraleph mraleph added the blocked label Dec 8, 2017

@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Dec 15, 2017

Member

First test runs of the new builders (non-precomp):
https://chromium-swarm.appspot.com/task?id=3a729aae75c79110
https://chromium-swarm.appspot.com/task?id=3a729c9bf0cc0310
https://chromium-swarm.appspot.com/task?id=3a729d40bc17d610
https://chromium-swarm.appspot.com/task?id=3a729d66c92f5e10

LUCI configuration is mostly completed. I still need to setup email notifications and enable them in the scheduler.

Member

athomas commented Dec 15, 2017

First test runs of the new builders (non-precomp):
https://chromium-swarm.appspot.com/task?id=3a729aae75c79110
https://chromium-swarm.appspot.com/task?id=3a729c9bf0cc0310
https://chromium-swarm.appspot.com/task?id=3a729d40bc17d610
https://chromium-swarm.appspot.com/task?id=3a729d66c92f5e10

LUCI configuration is mostly completed. I still need to setup email notifications and enable them in the scheduler.

@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Dec 18, 2017

Member

The builders are now enabled in the scheduler. To setup email notifications, I need to know where to send them, because I don't have blamelist support on LUCI, yet.

@mraleph Which email addresses should be notified? And when (on failure, on change, on success)?

Member

athomas commented Dec 18, 2017

The builders are now enabled in the scheduler. To setup email notifications, I need to know where to send them, because I don't have blamelist support on LUCI, yet.

@mraleph Which email addresses should be notified? And when (on failure, on change, on success)?

@a-siva

This comment has been minimized.

Show comment
Hide comment
@a-siva

a-siva Feb 16, 2018

Contributor

I am going to change the milestone of this bug to 2.0 alpha-2, we will track all stability issues on that milestone.

Contributor

a-siva commented Feb 16, 2018

I am going to change the milestone of this bug to 2.0 alpha-2, we will track all stability issues on that milestone.

@a-siva a-siva modified the milestones: 2.0-alpha1, 2.0-alpha2 Feb 16, 2018

@JekCharlsonYu JekCharlsonYu modified the milestones: 2.0-alpha2, I/O Beta 2 Feb 23, 2018

@dgrove

This comment has been minimized.

Show comment
Hide comment
@dgrove

dgrove Feb 26, 2018

Member

@athomas Any updates on this?

Member

dgrove commented Feb 26, 2018

@athomas Any updates on this?

@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Feb 26, 2018

Member

The configurations mentioned in #31573 (comment) are all running now. The remaining issue for this is blamelist emails which is tracked elsewhere: https://bugs.chromium.org/p/chromium/issues/detail?id=808193

Member

athomas commented Feb 26, 2018

The configurations mentioned in #31573 (comment) are all running now. The remaining issue for this is blamelist emails which is tracked elsewhere: https://bugs.chromium.org/p/chromium/issues/detail?id=808193

@athomas athomas closed this Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment