Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
This is a generalization of the issue raised in http://code.google.com/p/dart/issues/detail?id=472 - Underspecified Set<T> and Map<K,V> semantics
A silly example: it should be illegal for the default implementation of the Zoo interface (for managing any animal) be LionCage (where you can manage any animal you want, as long as it's a Lion).
Not only should issue #472 be fixed in the library, I'd argue the current implementation should be forbidden by the runtime.
The text was updated successfully, but these errors were encountered:
Added Area-Language, Triaged labels.
Sorry, something went wrong.
Unless we extensively revisit default implementations, this won't change. The flexibility is valuable.
Set owner to @gbracha.
Removed Type-Defect label.
Added Type-Enhancement, WontFix labels.
At this point, I realize enforcing such a rule in the tools might be impractical.
At a minimum, I would strongly argue for a best practice strongly discouraging the practice.
Flexibility is great, but it must be balanced with the principle of least surprise.
...I was VERY surprised. :-)
I love the quick replies to these issues. Blown away by the opennesses of the project. Cheers.
Bump pub to 8f5ab7b1aba3b9f66b56246d77e167990339d317
> git log --format="%C(auto) %h %s" dcb6aba..8f5ab7b
https://dart.googlesource.com/pub.git/+/8f5ab7b1 Avoid raceconditions in `global activate`, `run` and `global run` (#3285)
https://dart.googlesource.com/pub.git/+/6e03ec02 Support multiple packages in 'dart pub add' (#3283)
https://dart.googlesource.com/pub.git/+/1a298f4d Fix --verbose doc, and accept verboseness setting from embedder (#3279)
https://dart.googlesource.com/pub.git/+/5bda798c Avoid race condition for hosted source on package extraction (#3277)
https://dart.googlesource.com/pub.git/+/17c5addb Error on acquireDependencies when the root pubspec has an unknown sdk in the environment. (#3271)
https://dart.googlesource.com/pub.git/+/0a32ae4a folder/* should not ignore the folder itself, only the contents (#3267)
https://dart.googlesource.com/pub.git/+/44b785aa Normalize file names for tar.gz (#3268)
https://dart.googlesource.com/pub.git/+/2fd6b5f0 Fix repository specification: isRetracted -> retracted (#3249)
https://dart.googlesource.com/pub.git/+/0fc71db4 Write log trace to $PUB_CACHE/log/pub_log.txt when crashing (#3240)
Reviewed-by: Jonas Jensen <email@example.com>
Commit-Queue: Sigurd Meldgaard <firstname.lastname@example.org>
No branches or pull requests