Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two DDC test failures related to moving the analyzer to --use-fasta-parser #34041

Open
devoncarew opened this Issue Jul 31, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@devoncarew
Copy link
Member

devoncarew commented Jul 31, 2018

tests/corelib_2/corelib_2.status
  format_exception_test: RuntimeError
tests/language_2/language_2_dartdevc.status
  super_conditional_operator_test/01: Crash
@devoncarew

This comment has been minimized.

Copy link
Member Author

devoncarew commented Jul 31, 2018

@bwilkerson

This comment has been minimized.

Copy link
Member

bwilkerson commented Jul 31, 2018

@devoncarew

This comment has been minimized.

Copy link
Member Author

devoncarew commented Jul 31, 2018

And, cc'ing @vsmenon as well (note, the above CL has not yet landed).

@vsmenon

This comment has been minimized.

Copy link
Member

vsmenon commented Jul 31, 2018

Here's a link to the log:

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8939457313331647536/+/steps/ddc_tests/0/stdout

The first appears to be an issue with new lines.

The second is crashing in the analyzer:

AnalysisException: Cannot compute SOURCE_KIND for /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_tests/language_2/super_conditional_operator_test_01.dart
Caused by Unexpected exception while performing ParseDartTask for source /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_tests/language_2/super_conditional_operator_test_01.dart
#0      AnalysisTask._safelyPerform (package:analyzer/src/task/api/model.dart:335:7)
#1      AnalysisTask.perform (package:analyzer/src/task/api/model.dart:222:7)
#2      AnalysisDriver.performWorkItem (package:analyzer/src/task/driver.dart:285:10)
#3      AnalysisDriver.computeResult (package:analyzer/src/task/driver.dart:110:22)
#4      AnalysisContextImpl.computeResult (package:analyzer/src/context/context.dart:717:14)
#5      AnalysisContextImpl.computeKindOf (package:analyzer/src/context/context.dart:675:14)
#6      ModuleCompiler.compile (package:dev_compiler/src/analyzer/module_compiler.dart:162:19)

dart-bot pushed a commit that referenced this issue Sep 6, 2018

Improve super initializer recovery
This CL addresses one of the issues in #34041
by fixing an AstBuilder crash and improving recovery of super constructor calls
in a constructor initializer list.

In addition, this adds a TestDescriptor adjustValidUnitBeforeComparison field
to support the new recovery tests.

Change-Id: I9e687aed34ea293700bd45d7c13ce36e83a00a05
Reviewed-on: https://dart-review.googlesource.com/73286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.