Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE should not allow redirection from const to non-const constructor #34161

Closed
askeksa-google opened this issue Aug 16, 2018 · 2 comments

Comments

@askeksa-google
Copy link
Contributor

commented Aug 16, 2018

CFE version of #27617

Caught by language_2/regress_27617_test.

@askeksa-google askeksa-google added this to Triaged in Dart Front End Aug 20, 2018

@askeksa-google askeksa-google changed the title Redirection from const to non-const constructor allowed CFE should not allow redirection from const to non-const constructor Aug 20, 2018

@askeksa-google

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2018

The same goes for factory constructors. See co19_2/Language/Classes/Constructors/Factories/const_modifier_t01 and co19_2/Language/Classes/Constructors/Factories/const_modifier_t02.

@dhil dhil self-assigned this Aug 21, 2018

@dart-bot dart-bot closed this in 6c812c2 Aug 23, 2018

@dhil dhil reopened this Aug 23, 2018

@dhil

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

Reopening, as it was unintentionally closed by the first CL. I will keep it open until I have landed the second CL that implements the check for factory constructors.

@dart-bot dart-bot closed this in 73a35c9 Aug 30, 2018

@askeksa-google askeksa-google moved this from Triaged to Done in Dart Front End Sep 3, 2018

@askeksa-google askeksa-google referenced this issue Sep 28, 2018
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.