Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdoc apjit training run fails when platform.dill includes bytecode #34305

Closed
zanderso opened this Issue Aug 30, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@zanderso
Copy link
Member

commented Aug 30, 2018

In a non-interpreter VM build, the create_sdk target fails when bytecode is included in the platform.dill unconditionally. That is, changing compile_platform("vm_platform") to do:

args += [ "--bytecode" ]

instead of

if (dart_use_interpreter) {
  args += [ "--bytecode" ]
}

Then,

$ ./tools/build.py -m release -a x64 create_sdk

Fails when building the dartdoc app-jit snapshot with:

Command failed: ./dart --deterministic --packages=/Users/zra/dart/sdk/.packages --snapshot=gen/dartdoc.dart.snapshot --snapshot-depfile=/Users/zra/dart/sdk/xcodebuild/ReleaseX64/gen/dartdoc.dart.snapshot.d --snapshot-kind=app-jit /Users/zra/dart/sdk/third_party/pkg/dartdoc/bin/dartdoc.dart --help
output:  fatal error: Could not find an option named "help".

Usage: dartdoc [OPTIONS]

    --[no-]a-dd-cr-os-sd-art                                   Add Crossdart links to the source code pieces.
    --a-mb-ig-uo-us-re-ex-po-rt-sc-or-er-mi-nC-on-fi-de-nce    Minimum scorer confidence to suppress warning on ambiguous reexport.
                                                               (defaults to "0.1")
...
-h, --h-elp                                                    Show command help.

Note the mysterious extra '-' characters in the flag names...

/cc @alexmarkov @crelier @a-siva

@zanderso zanderso changed the title dardoc apjit training run fails when platform.dill includes bytecode dartdoc apjit training run fails when platform.dill includes bytecode Aug 30, 2018

@alexmarkov alexmarkov self-assigned this Aug 31, 2018

@alexmarkov

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

This is another side-effect of sorting named parameters while generating bytecode.

@dart-bot dart-bot closed this in a867e2c Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.