New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate reload spends unreasonably large amount of time in CheckpointClasses #34461

Closed
aam opened this Issue Sep 13, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@aam
Contributor

aam commented Sep 13, 2018

Sample profile below:

image

cc @rmacnak-google

dart-bot pushed a commit that referenced this issue Sep 14, 2018

[vm] Add library private key to the Class hash function for reload.
This reduces isolate reload time on a given sample from ~2 seconds to ~200 milliseconds.
Remove ASSERT - you can have replacement finalized when original was non-finalized

Bug: #34461
Change-Id: I39dc5d67e97bd7c0d654cd751b6829b00337e967
Reviewed-on: https://dart-review.googlesource.com/74961
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
@aam

This comment has been minimized.

Show comment
Hide comment
@aam
Contributor

aam commented Sep 14, 2018

@aam aam closed this Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment