Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js should implement show: and hide: combinators #3454

Closed
gbracha opened this issue Jun 8, 2012 · 6 comments
Closed

dart2js should implement show: and hide: combinators #3454

gbracha opened this issue Jun 8, 2012 · 6 comments
Assignees
Labels
Milestone

Comments

@gbracha
Copy link
Contributor

@gbracha gbracha commented Jun 8, 2012

Per spec, section 12.2

Language issue #817

@kasperl
Copy link
Contributor

@kasperl kasperl commented Sep 3, 2012

Set owner to @johnniwinther.
Added this to the M1 milestone.

@kasperl
Copy link
Contributor

@kasperl kasperl commented Oct 11, 2012

Fixed in r13534.


Added Fixed label.

@efortuna
Copy link
Contributor

@efortuna efortuna commented Oct 11, 2012

This still needs a little work. Try running it in firefox on Windows. It fails. :-(


Added Triaged label.

@efortuna
Copy link
Contributor

@efortuna efortuna commented Oct 11, 2012

This still needs a little work. Try running it in firefox on Windows. It fails. :-(

@kasperl
Copy link
Contributor

@kasperl kasperl commented Oct 12, 2012

The log file that shows the error is here:

http://build.chromium.org/p/client.dart/builders/dart2js-ff-win7/builds/363/steps/dart2js%20tests/logs/stdio

It says:


@@@STEP_CLEAR@@@
@@@STEP_TEXT@ 55% +489 -0 @­@@

  1. build\ReleaseIA32\dart-sdk\bin\dart2js.bat --out=e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.js e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.dart
  2. python e:\b\build\slave\dart2js-ff-win7\build\dart\tools\testing\run_selenium.py --browser=ff --timeout=478 --out=e:/b/build/slave/dart2js-ff-win7/build/dart/build/ReleaseIA32/generated_tests/dart2js-ff/tests_language_import_core_no_prefix_test/test.html
    language/import_combinators_test
    test.dart: Compilation failed (step 1 of 2), exit code 1

pkg/unittest/html_config.dart:8:10: Warning: duplicated library name "'unittest'".
#library('unittest');
         ^^^^^^^^^^
pkg/unittest/unittest.dart:137:10: Warning: duplicated library name "'unittest'".
#library('unittest');
         ^^^^^^^^^^
tests/language/import_combinators_test.dart:7:1: library tags not allowed here
import "import1_lib.dart" show hide, show hide ugly;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.

FAILED: dart2js-ff release_ia32 language/import_combinators_test
Expected: pass
Actual: fail
Unexpected compile-time error.


Added Started label.

@peter-ahe-google
Copy link
Contributor

@peter-ahe-google peter-ahe-google commented Oct 12, 2012

This problem is fixed. Wrapping tests is what is broken. See issue #2264.


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.