Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end tests are running into errors when the deprecated --no-preview-dart-2 option is removed #34548

Closed
a-siva opened this issue Sep 22, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@a-siva
Copy link
Contributor

commented Sep 22, 2018

The VM is removing support for the option --no-preview-dart-2 option.

The front end was still using this option in some cases and the
CL https://dart-review.googlesource.com/c/sdk/+/75820 removes the option for these cases.

However this produces the following errors:

DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart --enable_asserts --ignore-unrecognized-flags --packages=/usr/local/google/home/asiva/workspace/dart-ws3/sdk/.packages /usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/test/fasta/tool_test.dart

exit code:
255

stdout:
Testing abcompile
Testing analyzer-compile
Testing compile
Testing compile-platform
Testing log
Testing outline
Testing parser
Testing run
Testing scanner
Testing dump-partial

stderr:
Unhandled exception:
Expect.equals(expected: <1>, actual: <254>, 'stdout:

stderr:
pkg/front_end/tool/_fasta/dump_partial.dart:1: Error: Import of 'MapEntry' (from 'package:kernel/ast.dart') hides import from 'dart:core'.

') fails.
#0 Expect._fail (package:expect/expect.dart:651:5)
#1 Expect.equals (package:expect/expect.dart:124:5)
#2 main (file:///usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/test/fasta/tool_test.dart:162:12)
#3 _startIsolate. (dart:isolate/runtime/libisolate_patch.dart:289:19)
#4 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

--- Re-run this test:
python tools/test.py -m release -n unittest-asserts-linux pkg/front_end/test/fasta/tool_test

DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart --enable_asserts --ignore-unrecognized-flags --packages=/usr/local/google/home/asiva/workspace/dart-ws3/sdk/.packages /usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/tool/_fasta/compile_platform_legacy_test.dart

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Setting VM flags failed: Unrecognized flags: preview_dart_2
Unhandled exception:
Expect.equals(expected: <0>, actual: <255>, 'Non-zero exitcode from compile_platform.dart') fails.
#0 Expect._fail (package:expect/expect.dart:651:5)
#1 Expect.equals (package:expect/expect.dart:124:5)
#2 main.. (file:///usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/tool/_fasta/compile_platform_legacy_test.dart:36:14)

#3 withTemporaryDirectory (file:///usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/tool/_fasta/compile_platform_legacy_test.dart:47:12)

#4 main. (file:///usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/tool/_fasta/compile_platform_legacy_test.dart:21:11)

#5 asyncTest (package:async_helper/async_helper.dart:88:11)
#6 main (file:///usr/local/google/home/asiva/workspace/dart-ws3/sdk/pkg/front_end/tool/_fasta/compile_platform_legacy_test.dart:20:3)
#7 _startIsolate. (dart:isolate/runtime/libisolate_patch.dart:287:32)
#8 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)

--- Re-run this test:
python tools/test.py -m release -n unittest-asserts-linux pkg/front_end/tool/_fasta/compile_platform_legacy_test

@a-siva

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2018

@peter-ahe-google peter-ahe-google self-assigned this Sep 24, 2018

@peter-ahe-google

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

Proposed fix.

@dart-bot dart-bot closed this in fe39691 Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.