New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we should set up a head-to-head bot for flutter analyze #34739

Closed
devoncarew opened this Issue Oct 9, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@devoncarew
Member

devoncarew commented Oct 9, 2018

We'd like to set up a head-to-head bot for flutter analyze. This would do something like:

  • on every sdk commit, build the dart sdk (build.py -mrelease create_sdk)
  • git clone the flutter repo; this could just the the latest commit - we don't need to create a serialized commit stream of the dart and flutter repo commits
  • run something like flutter update-packages to make sure the flutter checkout has up to date .packages files
  • run a flutter analyze related command. Two good options here are either flutter analyzer --flutter-repo --dart-sdk=path/to/my/sdk, or dart dev/bots/analyze.dart --dart-sdk path/to/my/sdk

cc @kmillikin, as once we have something like this set up, a similar setup might be useful for the CFE

@devoncarew

This comment has been minimized.

Show comment
Hide comment
@devoncarew

devoncarew Oct 10, 2018

Member

Ah, and two more things:

  • the more of the implementation for this bot that can live in the sdk repo, the easier it'll be for people to work on and maintain
  • I'm happy to help out here however necessary :)
Member

devoncarew commented Oct 10, 2018

Ah, and two more things:

  • the more of the implementation for this bot that can live in the sdk repo, the easier it'll be for people to work on and maintain
  • I'm happy to help out here however necessary :)
@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Oct 10, 2018

Member

@devoncarew Suggestion: make it possible to specify what flutter/flutter ref to checkout. That would make it possible to checkout a PR instead of HEAD (the default). This would only work from the command line, not from Gerrit but would allow people to create experimental code in a Flutter PR and then test it with an SDK CL.

Member

athomas commented Oct 10, 2018

@devoncarew Suggestion: make it possible to specify what flutter/flutter ref to checkout. That would make it possible to checkout a PR instead of HEAD (the default). This would only work from the command line, not from Gerrit but would allow people to create experimental code in a Flutter PR and then test it with an SDK CL.

dart-bot pushed a commit that referenced this issue Oct 18, 2018

[infra] Add flutter-analyze builder to the test matrix (#34739)
Change-Id: I04d741753c89191ccb8706d02330c8404efc1eb8
Reviewed-on: https://dart-review.googlesource.com/c/80581
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Oct 18, 2018

Member

It's now possible to run this as an optional tryjob from Gerrit. What's remaining is to bring it up on CI.

Member

athomas commented Oct 18, 2018

It's now possible to run this as an optional tryjob from Gerrit. What's remaining is to bring it up on CI.

@devoncarew

This comment has been minimized.

Show comment
Hide comment
@devoncarew

devoncarew Oct 18, 2018

Member

Thanks! For people following along, the name to use is flutter-analyze.

Member

devoncarew commented Oct 18, 2018

Thanks! For people following along, the name to use is flutter-analyze.

dart-bot pushed a commit that referenced this issue Oct 22, 2018

[infra] Add analyzer branch alias for flutter-analyze builder (#34739)
* Channel detection only works for -dev, -stable and -try.
* This will allow adding flutter-analyze to the analyzer branch console.

TBR=whesse@google.com

Change-Id: I0a4036d290acdfba78ba138a0e87448f6da1e878
Reviewed-on: https://dart-review.googlesource.com/c/81101
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Oct 22, 2018

Member

https://ci.chromium.org/p/dart/g/analyzer/console now has column for the flutter-analyze builder. It should trigger on the next commit.

Member

athomas commented Oct 22, 2018

https://ci.chromium.org/p/dart/g/analyzer/console now has column for the flutter-analyze builder. It should trigger on the next commit.

@athomas

This comment has been minimized.

Show comment
Hide comment
@athomas

athomas Oct 23, 2018

Member

Closing this one since there is a separate issue to add the bot to the main waterfall.

Member

athomas commented Oct 23, 2018

Closing this one since there is a separate issue to add the bot to the main waterfall.

@athomas athomas closed this Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment