New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm/cc/IsolateReload_ComplexInheritanceChange crashes flakily on windows. #34744

Open
mkustermann opened this Issue Oct 10, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@mkustermann
Member

mkustermann commented Oct 10, 2018

From this buildbot log:

  FAILED: dartk-vm debug_x64 vm/cc/IsolateReload_ComplexInheritanceChange
  Expected: Pass
  Actual: Crash
  --- Command "run_vm_unittest" (took 02.000453s):
  set DART_CONFIGURATION=DebugX64 & out\DebugX64\run_vm_tests --dfe=out/DebugX64/gen/kernel-service.dart.snapshot --ignore-unrecognized-flags --use-dart-frontend --strong IsolateReload_ComplexInheritanceChange
  exit code:
  3
  stdout:
  Running test: IsolateReload_ComplexInheritanceChange
  stderr:
  RELOAD REPORT:
  {"type":"ReloadReport","success":true,"details":{"savedLibraryCount":18,"loadedLibraryCount":1,"finalLibraryCount":19,"shapeChangeMappings":[]}}
  c:\b\s\w\ir\cache\builder\sdk\runtime\vm\isolate_reload.cc: 1785: error: expected: cid < saved_num_cids_
  Dumping native stack trace for thread 1a30
    [0x000000014086261c] Dart_SetLibraryTagHandler
    [0x000000014086261c] Dart_SetLibraryTagHandler
  -- End of DumpStackTrace
  --- Re-run this test:
  python tools/test.py -m debug -n dartk-win-debug-x64 --output-directory C:\b\s\w\iof85nnc vm/cc/IsolateReload_ComplexInheritanceChange

I don't have a windows machine atm to try to reproduce this. It seems hot-reload related.

/cc @rmacnak-google @mraleph

@mkustermann mkustermann added the area-vm label Oct 10, 2018

@mkustermann

This comment has been minimized.

Show comment
Hide comment
@mkustermann

mkustermann Oct 10, 2018

Member

I'll not mark it in the status file, since it occurs not that frequently.

Member

mkustermann commented Oct 10, 2018

I'll not mark it in the status file, since it occurs not that frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment