Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Recover from minor performance regressions #35323
The control dep as data dep CL has landed and seems to stick. However, we had a few minor regressions (and one gain!) due to the change, most likely due to missed cases of looking under the hood of a check (but perhaps also due to missed LICM which may be unavoidable). This bug tracks if something can be done.
For SkeletalAnimation, the extra data dependence has no adverse impact on performance. The full difference can be explained by lack of LICM on the non-speculative checks (in the past, we would hoist the checks as speculative checks, and then later convert them to non-speculative).
In this case, all the checks
for such cases it is of course a waste not to hoist even non-speculative checks!