Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis server generates quickfixes that modify the Flutter SDK #35402

Closed
DanTup opened this Issue Dec 13, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@DanTup
Copy link
Member

DanTup commented Dec 13, 2018

Found by @bradmuzza at Dart-Code/Dart-Code#1341. If you call some Flutter framework code incorrectly, you may get quick-fixes that make modifications to the Flutter SDK source files:

screen shot 2018-12-13 at 1 07 36 pm

If you click Add required parameter, it'll insert this as a new param in the definition of IconButton.

Note: In VS Code, this results in the file being opened, made dirty, and a "You're modifying a file outside your workspace" message, however it's still pretty easy for a user to just hit Save All or something and end up with a broken SDK.

This is similar to #33181 where it was deemed that generated edits outside of the analysis roots probably didn't make sense, so I think the same logic could work here (rather than being specific to the Flutter SDK).

cc @bwilkerson @scheglov

@stereotype441

This comment has been minimized.

Copy link
Member

stereotype441 commented Dec 13, 2018

I would have expected this issue to be taken care of by Konstantin's fix to #35301. @scheglov can you investigate? Is it possible that your fix only addressed refactorings and not quick fixes?

@scheglov

This comment has been minimized.

Copy link
Contributor

scheglov commented Dec 14, 2018

dart-bot pushed a commit that referenced this issue Dec 14, 2018

Use ChangeWorkspace to limit where DartChangeBuilder(s) can edit.
R=brianwilkerson@google.com

Bug: #35402
Change-Id: If5f78b44b69f01d9ddc235401f70cc4aefd3ca37
Reviewed-on: https://dart-review.googlesource.com/c/87382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.