New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some new co19_2 tests of experimental features failing on the analyzer #35615

Open
whesse opened this Issue Jan 9, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@whesse
Copy link
Member

whesse commented Jan 9, 2019

Some co19_2 tests of experimental features are now behaving differently, since the

// SharedOptions=--enable-experiment=constant-update-2018
and
// SharedOptions=--enable-experiment=set-literals

annotations in co19_2 test source are being obeyed after landing
https://dart-review.googlesource.com/c/sdk/+/88704
which makes test.py treat co19_2 tests the same as all other tests.

These have been preapproved, to land the CL, but these failures should be investigated and fixed.
If they are mistakes in the test, issues should be filed against the dart-lang/co19 repository to fix them.

BOT TEST RESULT EXPECTED
analyzer-linux-release/ co19_2/LanguageFeatures/Constant_update2018/TypeTestOperator_A04_t01 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Constant_update2018/TypeTestOperator_A04_t02 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/semantics_A01_t01/01 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/semantics_A01_t01/02 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/semantics_A01_t01/09 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/semantics_A01_t01/10 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/set_literals_A03_t01/03 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/set_literals_A03_t01/04 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/set_literals_A03_t02/01 Pass Fail
analyzer-linux-release/ co19_2/LanguageFeatures/Set-literals/set_literals_A03_t02/02 Pass Fail

@whesse whesse added this to the Dart2.2 milestone Jan 9, 2019

@whesse

This comment has been minimized.

Copy link
Member

whesse commented Jan 9, 2019

Only the first 4 Set-literals test failures seem to be true failures of the analyzer: the following two expressions should be static errors (because an empty { } is a Map, not a Set)
// var v1 = {}; //# 01: compile-time error
// var v2 = const {}; //# 02: compile-time error

The last 4 errors in set_literals_A03_t01/03 and 04 and _t02/01 and 02 seem to be errors in the test - I have filed issue dart-lang/co19#220 about them.

@bwilkerson

This comment has been minimized.

Copy link
Member

bwilkerson commented Jan 9, 2019

Thanks for looking at the failures!

Actually, many of those tests are broken. I triaged them yesterday and opened issues, most of which have now been fixed. Here are the issues I opened (one per file rather than one per test):

dart-lang/co19#214
dart-lang/co19#215
dart-lang/co19#216
dart-lang/co19#217
dart-lang/co19#218
dart-lang/co19#219

@bwilkerson

This comment has been minimized.

Copy link
Member

bwilkerson commented Jan 9, 2019

(But as far as I know the fixes have not yet been rolled into our repo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment