New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm returning InstanceRefs for Class.library instead of LibraryRefs #35896

Open
devoncarew opened this Issue Feb 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@devoncarew
Copy link
Member

devoncarew commented Feb 10, 2019

Some context here: https://github.com/dart-lang/vm_service_drivers/pull/203/files#r249177374

For service protocol responses, we've seen the VM implementation return InstanceRefs for the Class.library field. This field is typed as a LibraryRef, and the difference between the spec'd type and the actual returned one causes problems for client implementation libraries (esp. after the change to strong mode).

cc @bkonyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment