New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the service protocol field Instance.closureContext is type as a ContextRef but returns InstanceRefs #35897

Open
devoncarew opened this Issue Feb 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@devoncarew
Copy link
Member

devoncarew commented Feb 10, 2019

See https://github.com/dart-lang/vm_service_drivers/pull/203/files#r249177795 for more context.

The field Instance.closureContext is spec'd to return a ContextRef. The VM implementation returns InstanceRefs here however. This causes issues in client libraries when we try and deserialize Instance objects.

cc @bkonyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment