Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI versioning #36047

Open
liamappelbe opened this issue Feb 27, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@liamappelbe
Copy link
Contributor

commented Feb 27, 2019

Tracking bug for work related to ABI versioning

@liamappelbe liamappelbe self-assigned this Feb 27, 2019

@kevmoo kevmoo added the area-vm label Feb 27, 2019

dart-bot pushed a commit that referenced this issue Mar 1, 2019

Add ABI_VERSION to the version file and a script to upload dills to CPID
Bug: #36047
Change-Id: I19d825eb2addaa32680d18a21d237ca172cd4b73
Reviewed-on: https://dart-review.googlesource.com/c/94442
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit that referenced this issue Mar 5, 2019

Add use_abi_version flag, and plumb ABI version to version.h
Bug: #36047
Change-Id: Ie810cbd5079e1939bf190e06f6c2494bb4ab0805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95282
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 5, 2019

Add upload_abi_dills.sh to dart-sdk-linux in test_matrix.json
Bug: #36047
Change-Id: I8e39df90a768ced8ce97d6496e4f411540225fb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95285
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 5, 2019

Update the build bot name restriction in upload_abi_dills.sh
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout

Bug: #36047
Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 6, 2019

Revert "Update the build bot name restriction in upload_abi_dills.sh"
This reverts commit 4eedef8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update the build bot name restriction in upload_abi_dills.sh
> 
> https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919793391094101904/+/steps/upload_abi_dills/0/stdout
> 
> Bug: #36047
> Change-Id: I35c6c6b8365007b681e0daf6e8ef8a5634370dd2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95488
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Icce78b35149d9a43dadeedcbfa97eb7153e8b74f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95560
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 6, 2019

Download ABI dills during gclient sync
This currently doesn't do anything because ABI_VERSION == OLDEST_SUPPORTED_ABI_VERSION, so there are no versions to download.

Bug: #36047
Change-Id: I5616151dd9dc407d918cbfe9044354f3a41a2e1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95300
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 6, 2019

Another attempt to fix the upload script.
Bug: #36047
Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 6, 2019

Revert "Another attempt to fix the upload script."
This reverts commit 0e57805.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919710985306895504/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Another attempt to fix the upload script.
> 
> Bug: #36047
> Change-Id: I2302bd3ee2072651cebcc1179e9778dc4c617965
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95662
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: Ibe5c52ae0005ea8aa0e69862a19b54cd64864974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95702
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 7, 2019

Attempt 3 at the upload abi dill script
Bug: #36047
Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 7, 2019

Revert "Attempt 3 at the upload abi dill script"
This reverts commit 94a382b.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919623995548729328/+/steps/upload_abi_dills/0/stdout

Original change's description:
> Attempt 3 at the upload abi dill script
> 
> Bug: #36047
> Change-Id: I1e8c28b30485e745fe773c2acfb334f4ef3aa1be
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95707
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,liama@google.com

Change-Id: I9eec3ca373ade1a7573eaa9999521c45213b060f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95881
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 7, 2019

Attempt 4 at the upload abi dills script
Bug: #36047
Change-Id: I89ddbcbd91d09f6a86a01e6d0b66798784a8c0eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95882
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 11, 2019

Fix the abi dills download script
Bug: #36047
Change-Id: Ic8b6cb0b1b5cb026bc06dd2ff414c026700a7c5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96133
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

dart-bot pushed a commit that referenced this issue Mar 12, 2019

Copy abi dills in create_sdk build rule
Bug: #36047
Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 12, 2019

Revert "Copy abi dills in create_sdk build rule"
This reverts commit 49a0502.

Reason for revert: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8919160881488492768/+/steps/build_host_debug/0/stdout

Original change's description:
> Copy abi dills in create_sdk build rule
> 
> Bug: #36047
> Change-Id: If73dbe5a62eff54ac0f712dada14ccd4c68c293e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96500
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=rmacnak@google.com,athom@google.com,asiva@google.com,liama@google.com

Change-Id: I90610bc43606a8cb148c9a3d9a1cab532176df8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96665
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 13, 2019

Reland https://dart-review.googlesource.com/c/sdk/+/96500
Rather than creating the abiversions directory during gclient update,
check in an (almost) empty directory. This fixes the flutter build.

Bug: #36047
Change-Id: Ied74210bfc1c8fda998f58f754eac3949ebe0718
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96846
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Mar 15, 2019

Move use_abi_version from vm directory to bin
I need to access the flag in bin/main.cc, so it can't be in the vm directory

Bug: #36047
Change-Id: Ib19a1b4d89295449b25f7753b2a39f6232c004e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97122
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

dart-bot pushed a commit that referenced this issue Mar 19, 2019

Include gen_kernel_bytecode in create_sdk so that it can be uploaded …
…by the builders

Bug: #36047
Change-Id: Ibe599c00345ea7ed2007f3d16b4d417c9ee8d3f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96540
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit that referenced this issue Mar 19, 2019

Add a build rule for bytecode version of kernel_service.dill
Bug: #36047
Change-Id: Ifc95ff270c33cce13699bda23c1b7c8fb6139e2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96835
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit that referenced this issue Mar 22, 2019

[vm] Load kernel service from ABI versioned dill file
Bug: #36047
Change-Id: I7122e8f0c8841be462e0fa0b28a75ef693d85d20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97260
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit that referenced this issue Mar 25, 2019

[vm] Add flags to gen_kernel script to support old ABIs
Bug: #36047
Change-Id: If6343223c03dc7f53d597294ef7a32c204236da6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97566
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

[vm] Allow running with the latest ABI dill files.
To support this, we need to download the current version during gclient
sync, and change the way the --use-abi-version flag is processed so that
there's a distinction between the current version and the flag being
unset (-1). Also bump the oldest supported ABI version.

Bug: #36047
Change-Id: If3fb5e1ba1ebddf11e9f0a9a7c42b7bb0b820ad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98609
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

Spawn isolates using platform kernel when using old ABIs
Bug: #36047
Change-Id: I4a95ec336e1ba6b955563cca5498a18310b51379
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98260
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

Revert "Spawn isolates using platform kernel when using old ABIs"
This reverts commit c3113b0.

Reason for revert: Broke some tests, eg https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8917089062837512336/+/steps/test_results/0/logs/tests_that_began_failing__logs_/0

Original change's description:
> Spawn isolates using platform kernel when using old ABIs
> 
> Bug: #36047
> Change-Id: I4a95ec336e1ba6b955563cca5498a18310b51379
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98260
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=asiva@google.com,liama@google.com

Change-Id: I33a714add2858752015dec38b8d973347a3ba79a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98684
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

Revert "[vm] Allow running with the latest ABI dill files."
This reverts commit 35c4af4.

Reason for revert: Broke a bunch of tests, eg:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8917088905682853152/+/steps/test_results/0/logs/tests_that_began_failing__logs_/0

Original change's description:
> [vm] Allow running with the latest ABI dill files.
> 
> To support this, we need to download the current version during gclient
> sync, and change the way the --use-abi-version flag is processed so that
> there's a distinction between the current version and the flag being
> unset (-1). Also bump the oldest supported ABI version.
> 
> Bug: #36047
> Change-Id: If3fb5e1ba1ebddf11e9f0a9a7c42b7bb0b820ad8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98609
> Commit-Queue: Liam Appelbe <liama@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=asiva@google.com,liama@google.com

Change-Id: I40f83fcc7f9d785353fb05d4296376ec04af8309
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98700
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

Reland "Spawn isolates using platform kernel when using old ABIs"
This reverts commit 2a8117c.

Reason for revert: I think it was actually https://dart-review.googlesource.com/c/sdk/+/98609 that caused the breakage

Original change's description:
> Revert "Spawn isolates using platform kernel when using old ABIs"
> 
> This reverts commit c3113b0.
> 
> Reason for revert: Broke some tests, eg https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8917089062837512336/+/steps/test_results/0/logs/tests_that_began_failing__logs_/0
> 
> Original change's description:
> > Spawn isolates using platform kernel when using old ABIs
> > 
> > Bug: #36047
> > Change-Id: I4a95ec336e1ba6b955563cca5498a18310b51379
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98260
> > Reviewed-by: Siva Annamalai <asiva@google.com>
> > Commit-Queue: Liam Appelbe <liama@google.com>
> 
> TBR=asiva@google.com,liama@google.com
> 
> Change-Id: I33a714add2858752015dec38b8d973347a3ba79a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: #36047
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98684
> Reviewed-by: Liam Appelbe <liama@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=asiva@google.com,liama@google.com

Change-Id: I8ce6b050f0c3aeb7ac4f15b83bbec0b3b0e909bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98688
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 4, 2019

Reland "[vm] Allow running with the latest ABI dill files."
This reverts commit 69ff056.

Reason for revert: Relanding with fix.

Original change's description:
> Revert "[vm] Allow running with the latest ABI dill files."
>
> This reverts commit 35c4af4.
>
> Reason for revert: Broke a bunch of tests, eg:
> https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8917088905682853152/+/steps/test_results/0/logs/tests_that_began_failing__logs_/0
>
> Original change's description:
> > [vm] Allow running with the latest ABI dill files.
> >
> > To support this, we need to download the current version during gclient
> > sync, and change the way the --use-abi-version flag is processed so that
> > there's a distinction between the current version and the flag being
> > unset (-1). Also bump the oldest supported ABI version.
> >
> > Bug: #36047
> > Change-Id: If3fb5e1ba1ebddf11e9f0a9a7c42b7bb0b820ad8
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98609
> > Commit-Queue: Liam Appelbe <liama@google.com>
> > Reviewed-by: Siva Annamalai <asiva@google.com>
>
> TBR=asiva@google.com,liama@google.com
>
> Change-Id: I40f83fcc7f9d785353fb05d4296376ec04af8309
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: #36047
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98700
> Reviewed-by: Liam Appelbe <liama@google.com>
> Commit-Queue: Liam Appelbe <liama@google.com>

TBR=asiva@google.com,liama@google.com

Change-Id: I909fd649eb41911a7b15e682b669708ebe083c8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #36047
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98690
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 11, 2019

Make download_abi_dills.py handle multiple abi verions not existing
Bug: #36047
Change-Id: Ifc8f92c6c098e86a06b94be153109214ca038eac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99090
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 11, 2019

Make download_abi_dills.py check that each ABI version exists
Simplifies the logic and makes it more robust, after:
https://dart-review.googlesource.com/c/sdk/+/99090

Bug: #36047
Change-Id: Ic7e6ef8f7bf5da930f8e2ce3cc712d992ad26652
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99201
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue Apr 12, 2019

test.py plumbing for ABI versions
Bug: #36047
Change-Id: I68ca1ad01dfb3126c1d8c7f60a87f47d392d2d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98745
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>

dart-bot pushed a commit that referenced this issue Apr 24, 2019

Wrapper script for running ABI tests
Bug: #36047
Change-Id: If2524c313c1ad9457f624830b683b28e2a425ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99281
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>

dart-bot pushed a commit that referenced this issue May 2, 2019

test_matrix.json changes for ABI tests
Bug: #36047
Change-Id: I7e9b5dcaf0d13c1e5b7b3354f5398b48d8cfc484
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99374
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.