Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmservice should not ignore exceptions when writing to the devfs #36202

Open
jonahwilliams opened this Issue Mar 13, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Mar 13, 2019

We've recently spent some time diagnosing a hot reload error on fuchsia. The underlying problem was: OS: ERROR 28 no space left on device. However, the devfs does not return a status code or error message indicating the failure. To verify this, we had to rebuild the vm_service with logging and print statements to confirm the issue.

For example, regardless of exceptions we respond with 200 OK.

https://github.com/dart-lang/sdk/blob/master/runtime/bin/vmservice/server.dart#L285

The actual failing call was in addStream from the devfs, but it wasn't caught or handled in anyway, leading to an unresponsive app.

https://github.com/dart-lang/sdk/blob/master/runtime/bin/vmservice/vmservice_io.dart#L153

var writeStreamFile = VMServiceEmbedderHooks.writeStreamFile;

@jonahwilliams

This comment has been minimized.

Copy link
Contributor Author

jonahwilliams commented Mar 13, 2019

@rmacnak-google

This comment has been minimized.

Copy link
Member

rmacnak-google commented Mar 15, 2019

devfs should be removed. It has nothing to do with introspecting the VM, and it does not belong in the VM service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.