Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: Implement "Control Flow Collections" #36214

Open
a-siva opened this Issue Mar 14, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@a-siva
Copy link
Contributor

a-siva commented Mar 14, 2019

Initially these features are behind the experimental flag control-flow-collections.

  • Support new block expression AST node

See:

Language tracking issue: dart-lang/language#165
Feature specification
Implementation plan

PENDING Unified Collections: dart-lang/language#200

@a-siva a-siva added the area-vm label Mar 14, 2019

@a-siva a-siva added this to the Dart2.3 milestone Mar 14, 2019

@munificent munificent referenced this issue Mar 14, 2019

Open

Implement "Control Flow Collections" #165

0 of 18 tasks complete
@aartbik

This comment has been minimized.

Copy link
Contributor

aartbik commented Mar 14, 2019

Just for proper book-keeping, the following CL provides an initial implementation of block expressions in the Dart VM:

https://dart-review.googlesource.com/c/sdk/+/94441

This should provide a fully functional implementation to continue testing, even though it still has some issues that could be improved (e.g. for now we just disable OSR completely while running control flow collections code for simplicity; this may be unacceptable in the long run).

@aartbik

This comment has been minimized.

Copy link
Contributor

aartbik commented Mar 15, 2019

Current status of control flow collections tests

             control-flow
JIT        +  190 | -   76
AOT        +  190 | -   76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.