Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: Implement support for constants being evaluated by front end #36220

Open
a-siva opened this Issue Mar 14, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@a-siva
Copy link
Contributor

a-siva commented Mar 14, 2019

This is the tracker issue for implementing support in the VM for constants being evaluated by the front end

  • Implement support in JIT mode
  • The bytecode compiler currently implements constant expression evaluation, with CFE doing it that becomes redundant
  • The AOT pipeline implements constant expression evaluation as a kernel to kernel transformation, with CFE doing it that becomes redundant

Language tracking issue: dart-lang/language#60
Frontend implementation tracking issue: #35079

@a-siva a-siva added the area-vm label Mar 14, 2019

@a-siva a-siva added this to the Dart2.3 milestone Mar 14, 2019

@a-siva

This comment has been minimized.

Copy link
Contributor Author

a-siva commented Mar 14, 2019

/cc @aartbik @alexmarkov who should own this issue?

@aartbik

This comment has been minimized.

Copy link
Contributor

aartbik commented Mar 14, 2019

I marked us both as owner for now. Alex probably wants to do the bytecode side. I can help with the other stuff after consulting with Alex.

dart-bot pushed a commit that referenced this issue Mar 20, 2019

[dart/vm] fix off-by-a-lot error in DAG test
Rationale:
The constant evaluator deals with two sorts of
offsets, the true offset into the kernel data,
and the offset of a constant relative to the
start of the constant table (compensated for a
variable-size int prefix at the true base).
The DAG test was comparing the latter against
the former (which was always true, since the
true offsets are much larger). This fixes
this omission.

#36220

Change-Id: I71f37bfb2bd3432e52d5086e89a62115f0cacacd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97421
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.