Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable constant-update-2018 shows major regressions in Flutter benchmarks #36611

Closed
a-siva opened this Issue Apr 12, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@a-siva
Copy link
Contributor

a-siva commented Apr 12, 2019

We are seeing major regressions in Flutter benchmarks with Enable constant-update-2018 being turned on by default. This is a show stopper and needs investigation.

48 Performance Regressions in 'Enable constant-update-2018 by default.'
The change Enable constant-update-2018 by default. has 48 Performance Regressions on Memegolem.

animation_bench_instructions_size	+10.4 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
animation_bench_instructions_size	+10 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
animation_bench_isolate_size	+8.29 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
animation_bench_isolate_size	+8.21 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
animation_bench_readonlydata_size	+10.1 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
animation_bench_readonlydata_size	+9.77 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
animation_bench_total_size	+9.93 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
animation_bench_total_size	+9.65 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
build_bench_instructions_size	+10.4 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
build_bench_instructions_size	+9.97 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
build_bench_isolate_size	+8.29 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
build_bench_isolate_size	+8.24 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
build_bench_readonlydata_size	+10.2 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
build_bench_readonlydata_size	+9.85 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
build_bench_total_size	+9.97 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
build_bench_total_size	+9.66 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
flutter_gallery_instructions_size	+12.6 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
flutter_gallery_instructions_size	+12.3 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
flutter_gallery_isolate_size	+12.7 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
flutter_gallery_isolate_size	+12.7 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
flutter_gallery_readonlydata_size	+12.5 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
flutter_gallery_readonlydata_size	+12.1 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
flutter_gallery_total_size	+12.6 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
flutter_gallery_total_size	+12.3 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
hello_world_instructions_size	+58.3 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
hello_world_instructions_size	+58.6 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
hello_world_isolate_size	+52.9 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
hello_world_isolate_size	+52.7 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
hello_world_readonlydata_size	+57.2 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
hello_world_readonlydata_size	+55.6 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
hello_world_total_size	+57 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
hello_world_total_size	+56.6 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
layout_bench_instructions_size	+10.5 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
layout_bench_instructions_size	+10 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
layout_bench_isolate_size	+8.3 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
layout_bench_isolate_size	+8.28 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
layout_bench_readonlydata_size	+10.2 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
layout_bench_readonlydata_size	+9.99 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
layout_bench_total_size	+10 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
layout_bench_total_size	+9.75 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
velocity_tracker_bench_instructions_size	+130 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
velocity_tracker_bench_instructions_size	+134 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
velocity_tracker_bench_isolate_size	+124 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
velocity_tracker_bench_isolate_size	+123 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
velocity_tracker_bench_readonlydata_size	+134 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
velocity_tracker_bench_readonlydata_size	+131 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise
velocity_tracker_bench_total_size	+130 %	CodeSize	flutter-profile	Moto G4	android-armv7	0 x larger than benchmark noise
velocity_tracker_bench_total_size	+131 %	CodeSize	flutter-profile	Moto G4	android-armv8	0 x larger than benchmark noise

@a-siva a-siva added this to the Dart 2.3 milestone Apr 12, 2019

@a-siva

This comment has been minimized.

Copy link
Contributor Author

a-siva commented Apr 12, 2019

@a-siva

This comment has been minimized.

Copy link
Contributor Author

a-siva commented Apr 12, 2019

This could be because vm_service is not being excluded from the release builds in the case of Flutter, the artifacts loaded by the engine build does not differentiate between the debug, release and product builds of platform.dill file and we end up using the debug version of platform.dill in the release builds causing vm_service to be included.

@vsmenon

This comment has been minimized.

Copy link
Member

vsmenon commented Apr 16, 2019

@aam - it looks like your downstream fix landed in flutter:

flutter/flutter#31063

Can we close this now?

@aam aam closed this Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.