Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in parsing of variables named `required` #36678

Closed
stereotype441 opened this issue Apr 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@stereotype441
Copy link
Member

commented Apr 19, 2019

@keertip found this testing the bleeding edge analyzer on some internal code. The analyzer currently (as of 9e87c16) rejects code like the following:

main() {
  var x = [];
  for (final required in x) {}
}

We have been discussing the possibility of making required a reserved word when NNBD is enabled, however even if we do so, we need it to keep working now, and we will need it to continue to work for opted-out libraries even after NNBD is released.

This bisects to @danrubel's commit ebdefa3.

Dan is on vacation today so I'm looking into doing a short-term fix by reverting ebdefa3 (as well as the follow-up commits that depend on it).

@danrubel

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

Looks like this problem has been here all along, but we only just bumped into it when I added "required" as a modifier. It also fails if I use "external" in place of "required". Working on a fix now.

@danrubel danrubel self-assigned this Apr 19, 2019

@stereotype441 stereotype441 removed their assignment Apr 19, 2019

@dart-bot dart-bot closed this in a2e06ea Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.