Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Flutter Widget transform needs to be performant #36976

Closed
vsmenon opened this issue May 15, 2019 · 7 comments

Comments

Projects
None yet
5 participants
@vsmenon
Copy link
Member

commented May 15, 2019

As part of landing the new const refactoring, we need to redo the flutter widget transform to do it correctly: #36640

This is a separate issue to validate that it is performant.

@vsmenon vsmenon added this to the D24 Release milestone May 15, 2019

@vsmenon

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@jacob314 @devoncarew - can someone on your team own the performance validation?

fyi - @askeksa-google

@jacob314

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I'm owning the performance validation.

@jacob314 jacob314 self-assigned this May 15, 2019

@aadilmaan aadilmaan added the p1-high label May 21, 2019

@aadilmaan

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@jacob314 Any progress update?

@devoncarew

This comment has been minimized.

Copy link
Member

commented May 21, 2019

@jacob314 may be OOO now. We'll need to de-prioritize this to a P2, or find a new owner (@askeksa-google, could that be you?).

@askeksa-google

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

It should be someone familiar with testing the performance of Flutter builds.

Though based on @jacob314's comments on flutter/engine#8994 I'd say we can just close this.

@devoncarew

This comment has been minimized.

Copy link
Member

commented May 22, 2019

👍

@devoncarew devoncarew closed this May 22, 2019

@jacob314

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.