Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer should support metadata annotation syntax #4056

Closed
gbracha opened this issue Jul 11, 2012 · 8 comments
Closed

Analyzer should support metadata annotation syntax #4056

gbracha opened this issue Jul 11, 2012 · 8 comments
Assignees
Labels
Milestone

Comments

@gbracha
Copy link
Contributor

@gbracha gbracha commented Jul 11, 2012

Per issue #3214.

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Jul 11, 2012

Added Waiting label.

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Aug 10, 2012

Added Triaged label.

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Aug 15, 2012

Set owner to @bwilkerson.

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Aug 17, 2012

@kasperl
Copy link
Contributor

@kasperl kasperl commented Sep 14, 2012

Can you guys verify that you allow metadata annotations in all the right places? Someone mentioned in passing that the implementation you have isn't complete (sorry that I do not have more details).

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Sep 14, 2012

Yes, unless the grammar has changed since we implemented this feature, we are accepting metadata in all of the places specified.

Until earlier this week our metadata support was incomplete in that we were not recording the parsed information in the element model and hence not using it to ensure correctness, but that has been fixed for the two kinds of metadata defined in the "meta" package: @­override and @­deprecated.

@gbracha
Copy link
Contributor Author

@gbracha gbracha commented Sep 14, 2012

I'm not sure about timelines, but metadata on type variables is one thing
that might have come in a tad later, so please check that.

@bwilkerson
Copy link
Member

@bwilkerson bwilkerson commented Sep 17, 2012

Confirmed that metadata on type variables was indeed added after we implemented the feature (unless we just missed it the first time around). It has now been added.

@gbracha gbracha added this to the M1 milestone Sep 17, 2012
@gbracha gbracha mentioned this issue Jun 3, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.