-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pub.dartlang.org should more thoroughly validate packages #5094
Comments
This comment was originally written by @butlermatt If doing this, should pub make the same validation when using pub install/update? Current pub validates that the name is exists but it does not appear to have constraints on what the name is. For instance can have capital letters, spaces, even reserved words (String). |
I think we want to be somewhat more lenient on the install side to support Git repos that may not be entirely up-to-snuff. |
This comment was originally written by @butlermatt Sounds good to me. Also gives private repositories a little leeway as well. So long as it is well documented that the naming convention is enforced. Thanks |
See also issue #7045. |
Removed Type-Defect label. |
Removed Area-Pub label. |
This comment was originally written by @zoechi I couldn't find a place where the package naming conventions are documented. |
This isn't the place for questions like that. I've answered it on the StackOverflow post, but in the future queries like that belong on the mailing list. |
This comment was originally written by @zoechi Thanks for the references in your SO answer. This was not meant as a question rather a hint that it isn't documented. I tried to find something but Google search didn't come up with useful results besides this issue. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
This issue has been moved to Github as part of a migration. Please use the Issue on Github going forward: https://github.com/dart-lang/pub-dartlang/issues Added MovedToGithub label. |
This issue has been moved to dart-archive/pub-dartlang#293. |
Currently, pub.dartlang.org does very sparse validation on uploaded packages. It should also validate:
* That the package name follows the naming conventions (valid Dart identifier, doesn't conflict with any reserved words, all lower case).
The text was updated successfully, but these errors were encountered: