Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub.dartlang.org should more thoroughly validate packages #5094

Closed
nex3 opened this issue Sep 11, 2012 · 17 comments
Closed

pub.dartlang.org should more thoroughly validate packages #5094

nex3 opened this issue Sep 11, 2012 · 17 comments

Comments

@nex3
Copy link
Member

@nex3 nex3 commented Sep 11, 2012

Currently, pub.dartlang.org does very sparse validation on uploaded packages. It should also validate:

* That the package name follows the naming conventions (valid Dart identifier, doesn't conflict with any reserved words, all lower case).

  • That the package description is non-empty.
@DartBot
Copy link

@DartBot DartBot commented Sep 15, 2012

This comment was originally written by @butlermatt


If doing this, should pub make the same validation when using pub install/update?

Current pub validates that the name is exists but it does not appear to have constraints on what the name is. For instance can have capital letters, spaces, even reserved words (String).

Loading

@nex3
Copy link
Member Author

@nex3 nex3 commented Sep 15, 2012

I think we want to be somewhat more lenient on the install side to support Git repos that may not be entirely up-to-snuff.

Loading

@DartBot
Copy link

@DartBot DartBot commented Sep 15, 2012

This comment was originally written by @butlermatt


Sounds good to me. Also gives private repositories a little leeway as well. So long as it is well documented that the naming convention is enforced.

Thanks

Loading

@nex3
Copy link
Member Author

@nex3 nex3 commented Nov 30, 2012

See also issue #7045.

Loading

@munificent
Copy link
Member

@munificent munificent commented Dec 13, 2012

Removed this from the M2 milestone.
Added this to the M3 milestone.

Loading

@munificent
Copy link
Member

@munificent munificent commented Dec 13, 2012

Removed Type-Defect label.
Added Type-Enhancement label.

Loading

@munificent
Copy link
Member

@munificent munificent commented Feb 12, 2013

Removed this from the M3 milestone.
Added this to the M4 milestone.

Loading

@munificent
Copy link
Member

@munificent munificent commented Apr 18, 2013

Removed this from the M4 milestone.
Added this to the M5 milestone.

Loading

@munificent
Copy link
Member

@munificent munificent commented May 31, 2013

Removed this from the M5 milestone.
Added this to the Later milestone.

Loading

@munificent
Copy link
Member

@munificent munificent commented Aug 21, 2013

Removed Area-Pub label.
Added Area-PubSite label.

Loading

@DartBot
Copy link

@DartBot DartBot commented Jan 28, 2014

This comment was originally written by @zoechi


I couldn't find a place where the package naming conventions are documented.
http://stackoverflow.com/questions/21401244

Loading

@nex3
Copy link
Member Author

@nex3 nex3 commented Jan 29, 2014

I couldn't find a place where the package naming conventions are documented.
http://stackoverflow.com/questions/21401244

This isn't the place for questions like that. I've answered it on the StackOverflow post, but in the future queries like that belong on the mailing list.

Loading

@DartBot
Copy link

@DartBot DartBot commented Jan 29, 2014

This comment was originally written by @zoechi


Thanks for the references in your SO answer. This was not meant as a question rather a hint that it isn't documented. I tried to find something but Google search didn't come up with useful results besides this issue.

Loading

@kasperl
Copy link

@kasperl kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

Loading

@kasperl
Copy link

@kasperl kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

Loading

@nicolasgarnier
Copy link
Contributor

@nicolasgarnier nicolasgarnier commented Sep 29, 2014

This issue has been moved to Github as part of a migration. Please use the Issue on Github going forward: https://github.com/dart-lang/pub-dartlang/issues


Added MovedToGithub label.

Loading

@DartBot
Copy link

@DartBot DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/pub-dartlang#293.

Loading

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants