Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform.localHostname fails on Chinese Windows #52701

Closed
nielsenko opened this issue Jun 14, 2023 · 4 comments
Closed

Platform.localHostname fails on Chinese Windows #52701

nielsenko opened this issue Jun 14, 2023 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@nielsenko
Copy link 

final hostname = Platform.localHostname

fails with:

Dart Error: Dart_NewStringFromUTF8 expects argument 'str' to be valid UTF-8.

on Chinese Windows (Chinese GB2312). See also: flutter/flutter#111957 and realm/realm-dart#1319.

Seen on on Flutter 3.10.4, ie. Dart 3.0.3.

I couldn't find any open issues on this, so here you have it.
@srawlins srawlins added area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jun 14, 2023
@blagoev blagoev mentioned this issue Jun 15, 2023
Closed
@rmacnak-google rmacnak-google added library-io and removed area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). labels Jun 20, 2023
@rmacnak-google
Copy link
Contributor

@brianquinlan @aam

@lrhn lrhn added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Jun 21, 2023
@aam aam reopened this Aug 14, 2023
@aam
Copy link
Contributor

aam commented Aug 14, 2023 •
edited
Loading

https://dart-review.googlesource.com/c/sdk/+/320620 reverts the fix

@aam aam mentioned this issue Aug 14, 2023
Closed
@aam aam mentioned this issue Jan 3, 2024
Open
5 tasks
copybara-service bot pushed a commit that referenced this issue Feb 21, 2024
@aam
Reapply "[vm/win] Use wide-character api for local hostname on Windows."
35c6cc6 
This relands a fix for looking up hostname on Windows in utf8-aware fashion.
Previously this was reverted because the API was only introduced in Windows 8,
making this use of Windows API fail on Windows 7.
With Windows 7 no longer being a target, original fix can be relanded.

BUG=#52701
TEST=manually

Change-Id: I330048c8b92ce805b7bb7e3fa05c88fefe3a30b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353500
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@lrhn lrhn added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Apr 21, 2024
@parlough
Copy link
Member

@aam Can this be closed as fixed now that 35c6cc6 relanded your change?

@aam
Copy link
Contributor

aam commented Jun 20, 2024

Yes, it can.

@aam aam closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@srawlins @aam @lrhn @rmacnak-google @parlough @nielsenko