Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension type methods and mirrors? #54266

Closed
jensjoha opened this issue Dec 7, 2023 · 2 comments
Closed

Extension type methods and mirrors? #54266

jensjoha opened this issue Dec 7, 2023 · 2 comments
Assignees
@alexmarkov
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@jensjoha
Copy link
Contributor

jensjoha commented Dec 7, 2023

I initially tried mimicking the extension member support in mirrors for extension type member support in https://dart-review.googlesource.com/c/sdk/+/339960/1 but it failed and I gave up.
Someone (who knows something about mirrors?) should probably figure out if a change is actually needed and if so make it.

/cc @alexmarkov
@jensjoha jensjoha added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Dec 7, 2023
@alexmarkov alexmarkov self-assigned this Dec 7, 2023
@alexmarkov alexmarkov added P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team labels Dec 7, 2023
@alexmarkov
Copy link
Contributor

I'm not sure dart:mirrors support for extension types would be useful, but having a minimal support won't hurt. https://dart-review.googlesource.com/c/sdk/+/340284 adds dart:mirrors support for extension type members similarly to extension methods. This includes MethodMirror.isExtensionTypeMember and VariableMirror.isExtensionTypeMember getters.

@a-siva
Copy link
Contributor

a-siva commented Dec 7, 2023 •
edited
Loading

@alexmarkov should we really be providing this support.
dart:mirrors is an unsupported library and we don't want to make changes to it or adjust it for new language features.
My inclination would be to close this issue as 'not planned'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmarkov alexmarkov

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-siva @jensjoha @alexmarkov