Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to run dart2js with --minify with Editor #8751

Closed
DartBot opened this issue Feb 24, 2013 · 12 comments
Closed

Unclear how to run dart2js with --minify with Editor #8751

DartBot opened this issue Feb 24, 2013 · 12 comments

Comments

@DartBot
Copy link

@DartBot DartBot commented Feb 24, 2013

This issue was originally filed by @sethladd


I'm not sure how to run --minify with dart2js when using the Editor.

Right-click, run as JavaScript doesn't have a sub-option.

Going into Manage Run configurations, and nothing jumps out at me. (see screenshot)

Can we make this easier? JavaScript size is one of the most important metrics by which people judge Dart.

Thanks!

@DartBot
Copy link
Author

@DartBot DartBot commented Feb 24, 2013

This comment was originally written by @sethladd


Attachment:
Screenshot_2_20_13_9_14_PM.png (179.57 KB)

@DartBot
Copy link
Author

@DartBot DartBot commented Feb 24, 2013

This comment was originally written by @sethladd


Attachment:
[Screen Shot 2013-02-24 at 12.37.37 AM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-8751/comment-2/Screen Shot 2013-02-24 at 12.37.37 AM.png) (126.42 KB)

@DartBot
Copy link
Author

@DartBot DartBot commented Feb 24, 2013

This comment was originally written by googlegroups...@kaioa.com


Right now it's indeed very well hidden.

  1. right click your project's folder
  2. click on "Properties"
  3. go to "Dart Settings"
  4. write "--minify" in dart2js' "Additional flags" text field

Theoretically, you could also add "--output-type=dart" (dart2dart) there, but then you'd output a minified Dart file with ".js" extension whenever you run "Generate JavaScript".

This really needs some restructuring. Right now I use a batch file to run dart2dart. That's a little bit too low-tech for my taste. I'd prefer to do that from within the editor.

@anders-sandholm
Copy link
Contributor

@anders-sandholm anders-sandholm commented Feb 25, 2013

Removed Type-Defect label.
Added Type-Enhancement, Area-Editor, Triaged labels.

@danrubel
Copy link

@danrubel danrubel commented Feb 25, 2013

Set owner to @devoncarew.
Added this to the M5 milestone.

@sethladd
Copy link
Contributor

@sethladd sethladd commented Mar 14, 2013

Why isn't minify on by default?

@DartBot
Copy link
Author

@DartBot DartBot commented Mar 16, 2013

This comment was originally written by @sethladd


Answering my own question... minify is more of a deploy step.

@devoncarew
Copy link
Member

@devoncarew devoncarew commented May 28, 2013

Removed this from the M5 milestone.
Added this to the M6 milestone.

@devoncarew
Copy link
Member

@devoncarew devoncarew commented Aug 15, 2013

Removed this from the M6 milestone.
Added this to the M7 milestone.

@devoncarew
Copy link
Member

@devoncarew devoncarew commented Sep 19, 2013

Removed this from the M7 milestone.
Added this to the Later milestone.

@devoncarew
Copy link
Member

@devoncarew devoncarew commented Feb 11, 2014

This will be taken care of by pub build.


Added NotPlanned label.

@clayberg
Copy link

@clayberg clayberg commented Feb 11, 2014

Removed this from the Later milestone.
Added this to the 1.2 milestone.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants