Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912

Closed
munificent opened this issue Dec 19, 2011 · 13 comments

Comments

Projects
None yet
9 participants
@munificent
Copy link
Member

commented Dec 19, 2011

The current name is needlessly verbose, inconsistent, and doesn't match the style guide.

@rakudrama

This comment has been minimized.

Copy link
Member

commented Dec 20, 2011

Lets hope that dart:html will be able to export dart:dom's XmlHttpRequest simply by typedef.

@jacob314

This comment has been minimized.

Copy link
Member

commented Dec 22, 2011

This isn't a class that can be exported by typedef as we want to use XMLHttpRequest.on.load instead of XMLHttpRequest.addEventListener

@vsmenon

This comment has been minimized.

Copy link
Member

commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon

This comment has been minimized.

Copy link
Member

commented Jun 22, 2012

Set owner to @vsmenon.
Added this to the M1 milestone.

@iposva-google

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2012

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon

This comment has been minimized.

Copy link
Member

commented Aug 14, 2012

Issue #3133 has been merged into this issue.

@vsmenon

This comment has been minimized.

Copy link
Member

commented Aug 15, 2012

Removed Priority-Medium label.
Added Priority-High label.

@vsmenon

This comment has been minimized.

Copy link
Member

commented Aug 15, 2012

Set owner to @efortuna.

@sethladd

This comment has been minimized.

Copy link
Member

commented Aug 16, 2012

XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work)

See also issue #2677

@jmesserly

This comment has been minimized.

Copy link
Member

commented Aug 16, 2012

@seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax)

Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @­deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ...

@sethladd

This comment has been minimized.

Copy link
Member

commented Aug 16, 2012

This is a good opportunity to document HttpRequest. When we change the name, the MDN docs will be even less relevant.

@DartBot

This comment has been minimized.

Copy link

commented Aug 18, 2012

This comment was originally written by branflake...@gmail.com


Would ResourceRequest name be a better fit?

@efortuna

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2012

This was committed in r11070.


Added Fixed label.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.