Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912

Closed
munificent opened this issue Dec 19, 2011 · 13 comments
Closed

Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912

munificent opened this issue Dec 19, 2011 · 13 comments
Assignees
Labels
Milestone

Comments

@munificent
Copy link
Member

@munificent munificent commented Dec 19, 2011

The current name is needlessly verbose, inconsistent, and doesn't match the style guide.

@rakudrama
Copy link
Member

@rakudrama rakudrama commented Dec 20, 2011

Lets hope that dart:html will be able to export dart:dom's XmlHttpRequest simply by typedef.

@jacob314
Copy link
Member

@jacob314 jacob314 commented Dec 22, 2011

This isn't a class that can be exported by typedef as we want to use XMLHttpRequest.on.load instead of XMLHttpRequest.addEventListener

@vsmenon
Copy link
Member

@vsmenon vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

@vsmenon vsmenon commented Jun 22, 2012

Set owner to @vsmenon.
Added this to the M1 milestone.

@iposva-google
Copy link
Contributor

@iposva-google iposva-google commented Aug 13, 2012

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

@vsmenon vsmenon commented Aug 14, 2012

Issue #3133 has been merged into this issue.

@vsmenon
Copy link
Member

@vsmenon vsmenon commented Aug 15, 2012

Removed Priority-Medium label.
Added Priority-High label.

@vsmenon
Copy link
Member

@vsmenon vsmenon commented Aug 15, 2012

Set owner to @efortuna.

@sethladd
Copy link
Member

@sethladd sethladd commented Aug 16, 2012

XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work)

See also issue #2677

@jmesserly
Copy link
Contributor

@jmesserly jmesserly commented Aug 16, 2012

@seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax)

Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @­deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ...

@sethladd
Copy link
Member

@sethladd sethladd commented Aug 16, 2012

This is a good opportunity to document HttpRequest. When we change the name, the MDN docs will be even less relevant.

@DartBot
Copy link

@DartBot DartBot commented Aug 18, 2012

This comment was originally written by branflake...@gmail.com


Would ResourceRequest name be a better fit?

@efortuna
Copy link
Contributor

@efortuna efortuna commented Aug 21, 2012

This was committed in r11070.


Added Fixed label.

@munificent munificent added this to the M1 milestone Aug 21, 2012
dart-bot pushed a commit that referenced this issue Oct 12, 2020
2020-10-12 sgrekhov@unipro.ru #951. Changed error expectation to not to fail on tryjobs
2020-10-12 sgrekhov@unipro.ru #912. Added tests for external variable declaration

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I8e27b4a1605a9503056c3d18e0a8cd4b2d7b3383
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166848
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.