Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912

Closed
munificent opened this Issue Dec 19, 2011 · 13 comments

Projects

None yet

9 participants

@munificent
Member

The current name is needlessly verbose, inconsistent, and doesn't match the style guide.

@rakudrama
Member

Lets hope that dart:html will be able to export dart:dom's XmlHttpRequest simply by typedef.

@jacob314
Member

This isn't a class that can be exported by typedef as we want to use XMLHttpRequest.on.load instead of XMLHttpRequest.addEventListener

@vsmenon
Member
vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Member
vsmenon commented Jun 22, 2012

Set owner to @vsmenon.
Added this to the M1 milestone.

@iposva-google
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Member
vsmenon commented Aug 14, 2012

Issue #3133 has been merged into this issue.

@vsmenon
Member
vsmenon commented Aug 15, 2012

Removed Priority-Medium label.
Added Priority-High label.

@vsmenon
Member
vsmenon commented Aug 15, 2012

Set owner to @efortuna.

@sethladd
Member

XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work)

See also issue #2677

@jmesserly
Member

@Seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax)

Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @­deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ...

@sethladd
Member

This is a good opportunity to document HttpRequest. When we change the name, the MDN docs will be even less relevant.

@DartBot
Member
DartBot commented Aug 18, 2012

This comment was originally written by branflake...@gmail.com


Would ResourceRequest name be a better fit?

@efortuna
Contributor

This was committed in r11070.


Added Fixed label.

@efortuna efortuna was assigned by munificent Aug 21, 2012
@munificent munificent added this to the M1 milestone Aug 21, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment