Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912

Closed
munificent opened this Issue Dec 19, 2011 · 13 comments

Comments

Projects
None yet
9 participants
Member

munificent commented Dec 19, 2011

The current name is needlessly verbose, inconsistent, and doesn't match the style guide.

Member

rakudrama commented Dec 20, 2011

Lets hope that dart:html will be able to export dart:dom's XmlHttpRequest simply by typedef.

Member

jacob314 commented Dec 22, 2011

This isn't a class that can be exported by typedef as we want to use XMLHttpRequest.on.load instead of XMLHttpRequest.addEventListener

Member

vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

Member

vsmenon commented Jun 22, 2012

Set owner to @vsmenon.
Added this to the M1 milestone.

Contributor

iposva-google commented Aug 13, 2012

Removed Area-DOM label.
Added Area-HTML label.

Member

vsmenon commented Aug 14, 2012

Issue #3133 has been merged into this issue.

Member

vsmenon commented Aug 15, 2012

Removed Priority-Medium label.
Added Priority-High label.

Member

vsmenon commented Aug 15, 2012

Set owner to @efortuna.

Member

sethladd commented Aug 16, 2012

XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work)

See also issue #2677

Member

jmesserly commented Aug 16, 2012

@seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax)

Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @­deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ...

Member

sethladd commented Aug 16, 2012

This is a good opportunity to document HttpRequest. When we change the name, the MDN docs will be even less relevant.

Member

DartBot commented Aug 18, 2012

This comment was originally written by branflake...@gmail.com


Would ResourceRequest name be a better fit?

Contributor

efortuna commented Aug 21, 2012

This was committed in r11070.


Added Fixed label.

efortuna was assigned by munificent Aug 21, 2012

munificent added this to the M1 milestone Aug 21, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment