Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename "XMLHttpRequest" -> "HttpRequest" in dart:html #912
XMLHttpRequest is a mainstay name for web developers. I don't support changing the name unless we significantly enhance the interface, make is Darty, and unify it with dart:io's HttpRequest. If we do so, we must heavily document that XMLHttpRequest is now HttpRequest (so the inevitable searches will still work)
See also issue #2677
@seth: yeah, we're going to do that--make it Darty and unify with dart:io :). We need to get dart:html types to be as nice as jQuery APIs (e.g. jQuery.ajax)
Totally agree on needing some way to help people find the new names. I find this issue with lots of the DOM apis. one idea is to "typedef" the old names and make them @deprecated pointing at the new names. Basically some other way to tell the editor to help users when they try to use "XMLHttpRequest", "HTMLElement", or "appendChild" etc ...
2020-10-12 firstname.lastname@example.org #951. Changed error expectation to not to fail on tryjobs 2020-10-12 email@example.com #912. Added tests for external variable declaration Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I8e27b4a1605a9503056c3d18e0a8cd4b2d7b3383 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166848 Commit-Queue: Alexander Thomas <firstname.lastname@example.org> Auto-Submit: Alexander Thomas <email@example.com> Reviewed-by: William Hesse <firstname.lastname@example.org>