Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in the latest stable version of pub. #24244

Closed
wants to merge 1 commit into from
Closed

Bring in the latest stable version of pub. #24244

wants to merge 1 commit into from

Conversation

@nex3
Copy link
Member

@nex3 nex3 commented Aug 31, 2015

This fixes three issues with the 1.12.0 changes:

  • Pub will now respect .gitignore when validating a package before it's
    published. For example, if a LICENSE file exists but is ignored, that is
    now an error.
  • If the package is in a subdirectory of a Git repository and the entire
    subdirectory is ignored with .gitignore, pub will act as though nothing
    was ignored instead of uploading an empty package.
  • The heuristics for determining when pub get needs to be run before various
    commands have been improved. There should no longer be false positives when
    non-dependency sections of the pubspec have been modified.
@mit-mit
Copy link
Member

@mit-mit mit-mit commented Sep 1, 2015

nex3@, please clarify why this is needed now. 1.12 is only one day old. Can we not do this in 1.13?

Loading

@mit-mit
Copy link
Member

@mit-mit mit-mit commented Sep 1, 2015

Discussed with Bill, this can piggy back if there is another, urgent request for a 1.12 MergeToStable.

Loading

@nex3
Copy link
Member Author

@nex3 nex3 commented Sep 1, 2015

@mit-mit It's bug fixes for functionality in 1.12—isn't that what the stable channel is for?

Loading

@sethladd sethladd added this to the 1.12.1 milestone Sep 1, 2015
@munificent
Copy link
Member

@munificent munificent commented Sep 3, 2015

I have a matching patch to bring this into bleeding edge: https://codereview.chromium.org/1326953005/

Loading

@whesse
Copy link
Member

@whesse whesse commented Sep 8, 2015

Merged in version 1.12.1.

Loading

@whesse whesse closed this Sep 8, 2015
@whesse whesse deleted the stable-pub branch Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants