Skip to content

Faster isNotEmpty on collections #34751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teresy wants to merge 1 commit into from
Closed

Faster isNotEmpty on collections #34751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/generated/error_verifier.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4121,7 +4121,7 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
InterfaceType mixinSupertype = mixinElement.supertype;
if (mixinSupertype != null) {
if (!mixinSupertype.isObject ||
!mixinElement.isMixinApplication && mixinElement.mixins.length != 0) {
!mixinElement.isMixinApplication && mixinElement.mixins.isNotEmpty) {
_errorReporter.reportErrorForNode(
CompileTimeErrorCode.MIXIN_INHERITS_FROM_NOT_OBJECT,
mixinName,
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class NsmEmitter extends CodeEmitterHelper {
int type, List argNames, Selector selector, jsAst.Name internalName) {
if (!generateTrivialNsmHandlers) return false;
// Check for named arguments.
if (argNames.length != 0) return false;
if (argNames.isNotEmpty) return false;
if (selector.typeArgumentCount > 0) return false;
// Check for unexpected name (this doesn't really happen).
if (internalName is GetterName) return type == 1;
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/lib/src/ssa/builder_kernel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ class KernelSsaGraphBuilder extends ir.Visitor
new SubGraph(defaultCase, defaultCase)));
}
assert(caseHandlers.length == joinBlock.predecessors.length);
if (caseHandlers.length != 0) {
if (caseHandlers.isNotEmpty) {
graph.addBlock(joinBlock);
open(joinBlock);
if (caseHandlers.length == 1) {
Expand Down