From 8d27d9ab7da4a3b978545b4598f4a25622320cd7 Mon Sep 17 00:00:00 2001 From: wtoalabi Date: Tue, 15 Jan 2019 12:10:29 +0100 Subject: [PATCH 1/4] Added the right conjunction Corrected the word "provide" to "provided" as the right conjunction within the given context. --- sdk/lib/core/list.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart index 4e78c2a9e76e..933afa61eb1d 100644 --- a/sdk/lib/core/list.dart +++ b/sdk/lib/core/list.dart @@ -636,7 +636,7 @@ abstract class List implements EfficientLengthIterable { * list1.setRange(1, 3, list2, 3); * list1.join(', '); // '1, 8, 9, 4' * - * The provide range, given by [start] and [end], must be valid. + * The provided range, given by [start] and [end], must be valid. * A range from [start] to [end] is valid if `0 <= start <= end <= len`, where * `len` is this list's `length`. The range starts at `start` and has length * `end - start`. An empty range (with `end == start`) is valid. From 3f26b6147b079705cc07b635e7bb7b597cc65e44 Mon Sep 17 00:00:00 2001 From: wtoalabi Date: Tue, 15 Jan 2019 12:30:26 +0100 Subject: [PATCH 2/4] Added the right conjunction within comments There are many instances where the word "provide" was used instead of "provided". --- sdk/lib/core/list.dart | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart index 933afa61eb1d..66de4e5e5f61 100644 --- a/sdk/lib/core/list.dart +++ b/sdk/lib/core/list.dart @@ -607,7 +607,7 @@ abstract class List implements EfficientLengthIterable { * Returns an [Iterable] that iterates over the objects in the range * [start] inclusive to [end] exclusive. * - * The provide range, given by [start] and [end], must be valid at the time + * The provided range, given by [start] and [end], must be valid at the time * of the call. * * A range from [start] to [end] is valid if `0 <= start <= end <= len`, where @@ -656,7 +656,7 @@ abstract class List implements EfficientLengthIterable { /** * Removes the objects in the range [start] inclusive to [end] exclusive. * - * The provide range, given by [start] and [end], must be valid. + * The provided range, given by [start] and [end], must be valid. * A range from [start] to [end] is valid if `0 <= start <= end <= len`, where * `len` is this list's `length`. The range starts at `start` and has length * `end - start`. An empty range (with `end == start`) is valid. @@ -670,7 +670,7 @@ abstract class List implements EfficientLengthIterable { * Sets the objects in the range [start] inclusive to [end] exclusive * to the given [fillValue]. * - * The provide range, given by [start] and [end], must be valid. + * The provided range, given by [start] and [end], must be valid. * A range from [start] to [end] is valid if `0 <= start <= end <= len`, where * `len` is this list's `length`. The range starts at `start` and has length * `end - start`. An empty range (with `end == start`) is valid. @@ -685,7 +685,7 @@ abstract class List implements EfficientLengthIterable { * list.replaceRange(1, 4, [6, 7]); * list.join(', '); // '1, 6, 7, 5' * - * The provide range, given by [start] and [end], must be valid. + * The provided range, given by [start] and [end], must be valid. * A range from [start] to [end] is valid if `0 <= start <= end <= len`, where * `len` is this list's `length`. The range starts at `start` and has length * `end - start`. An empty range (with `end == start`) is valid. From 0a280babb65c2dec5d3989a6d90f6d0e4b46f85e Mon Sep 17 00:00:00 2001 From: wtoalabi Date: Thu, 17 Jan 2019 08:45:57 +0100 Subject: [PATCH 3/4] Added an appropriate comma within comment. --- sdk/lib/developer/developer.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/lib/developer/developer.dart b/sdk/lib/developer/developer.dart index 6c3fa826c499..c446fdf153e8 100644 --- a/sdk/lib/developer/developer.dart +++ b/sdk/lib/developer/developer.dart @@ -30,7 +30,7 @@ part 'timeline.dart'; /// Returns the value of [when]. Some debuggers may display [message]. /// /// NOTE: When invoked, the isolate will not return until a debugger -/// continues execution. When running in the Dart VM the behaviour is the same +/// continues execution. When running in the Dart VM, the behaviour is the same /// regardless of whether or not a debugger is connected. When compiled to /// JavaScript, this uses the "debugger" statement, and behaves exactly as /// that does. From 0e78929faf5abd204c03471263813000f92db1df Mon Sep 17 00:00:00 2001 From: wtoalabi Date: Fri, 8 Mar 2019 10:04:34 +0100 Subject: [PATCH 4/4] Update isolate.dart --- sdk/lib/isolate/isolate.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart index 6e43fb7635e9..6a737fea2384 100644 --- a/sdk/lib/isolate/isolate.dart +++ b/sdk/lib/isolate/isolate.dart @@ -40,7 +40,7 @@ class IsolateSpawnException implements Exception { * * An `Isolate` object is a reference to an isolate, usually different from * the current isolate. - * It represents, and can be used control, the other isolate. + * It represents, and can be used to control, the other isolate. * * When spawning a new isolate, the spawning isolate receives an `Isolate` * object representing the new isolate when the spawn operation succeeds.