Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md #128

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update CHANGELOG.md #128

merged 3 commits into from
Apr 9, 2024

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Apr 9, 2024

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mit-mit mit-mit requested a review from athomas April 9, 2024 08:38
@athomas athomas merged commit 65c8298 into main Apr 9, 2024
27 checks passed
@athomas athomas deleted the mit-mit-patch-1 branch April 9, 2024 10:18
@devoncarew
Copy link
Member

I don't think #127 addressed this; we bundle the compiled dart + js as part of the distro (https://github.com/dart-lang/setup-dart/blob/main/DEVELOPING.md). npm run all will recompile the dart and minify that and the js into dist/index.mjs, and that should all get committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants