New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Site changes due to upgrade to Angular 5 and Dart 2 #1369

Open
chalin opened this Issue Mar 3, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@chalin
Collaborator

chalin commented Mar 3, 2018

This is a meta issue used to track the completion status of the 5-dev branch. Items are in no particular order at the moment, and mainly list major work items, not minutia.

  • Updates due to use of Dart 2 are tracked using #1366
  • Tutorial
    • Setup: explaining new way to serve apps
    • Parts 5 and 6: use router v2 - #361, #1058
  • Guides
    • Router, due to v2 API rewrite - #1058
  • Component testing
    • Explain new way to run tests
    • Temporarily use mock pageloader until pageloader v3 is released - #1350
    • Update to pageloader v3 - #1351
  • angular-examples repos:
    • README (#1431)
    • gh-pages with updated app
  • WebStorm - #1582
    • Update screenshots
    • Adjust warning to mention min version
  • Remove unnecessary new/const? - #1650
    Waiting on dart-lang/angular#1313

Also:

  • Pages to review before Angular 5 final #1422

@chalin chalin added this to the ng5-dev_18Q1 milestone Mar 3, 2018

@chalin chalin changed the title from [5-dev] Site changes due to upgrade to Angular 5 and Dart 2 to [Meta] Site changes due to upgrade to Angular 5 and Dart 2 Mar 3, 2018

chalin added a commit that referenced this issue Mar 22, 2018

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file
Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

chalin added a commit that referenced this issue Mar 22, 2018

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file
Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

chalin added a commit that referenced this issue Mar 22, 2018

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)
Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

chalin added a commit that referenced this issue Mar 24, 2018

[5-dev] Angular 5-alpha+8, SDK 2-dev.40, toh-5/6 updates to router 2
#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

chalin added a commit that referenced this issue Apr 4, 2018

[5-dev] Angular 5-alpha+8, SDK 2-dev.40, toh-5/6 updates to router 2
#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

chalin added a commit that referenced this issue Apr 4, 2018

[5-dev] Angular 5-alpha+8, SDK 2-dev.43
#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

[5-dev] Upgrade SDK to 2-dev.42 (#1428)

Updated pubspec.lock files

[5-dev] Router example: fix crisis selection and other misc fixes (#1430)

[5-dev] Remove "Dartium", "content shell", and pub transformers (#1429)

* [5-dev] Remove "Dartium" and "content shell"

* Drop Dartium page and logo; setup firebase redirect

* Drop pub and transformer pages; redirect to dart-2

* Post-review edits

[5-dev] Routing example updates (CanReuse) + some minor toh field renaming (#1435)

* Router example: add CanReuse + some cleanup

* Examples(toh-*): field rename

* Router field rename

* Router example: use InstanceLogger

[5-dev] Router guide overview cleanup; show all guide pages (#1439)

[5-dev] Upgrade SDK to 2-dev.43 (#1441)

[5-dev] Enable use of angular_analyzer_plugin + minor tutorial refactorings (#1442)

* toh-1, toh-2

* toh-3

* toh-4

* toh-5

* toh-6

* Router updates

* Updates to all other example analysis_options.yaml files

(Add back `strong-mode: true`)

* toh-2 prose tweak

[5-dev] Enable router page link checks; fix link anchors (#1443)

[5-dev] Upgrade ACX, Angular 5-alpha+8 (#1446)

[5-dev] Fix pipes example (#1447)

[5-dev] toh-2: fix code excerpt so it includes click event binding (#1449)

Fixes #1448

Change build_runner links to point to pub (#1453)

...instead of the README in the repo.

@chalin chalin referenced this issue Apr 4, 2018

Closed

2018Q2 top priority work items #1456

3 of 33 tasks complete

@chalin chalin modified the milestones: ng5-dev_18Q1, ng5-dev_18Q2 Apr 4, 2018

chalin added a commit that referenced this issue Apr 10, 2018

[5-dev] Angular 5-alpha+8, SDK 2-dev.46
#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

[5-dev] Upgrade SDK to 2-dev.42 (#1428)

Updated pubspec.lock files

[5-dev] Router example: fix crisis selection and other misc fixes (#1430)

[5-dev] Remove "Dartium", "content shell", and pub transformers (#1429)

* [5-dev] Remove "Dartium" and "content shell"

* Drop Dartium page and logo; setup firebase redirect

* Drop pub and transformer pages; redirect to dart-2

* Post-review edits

[5-dev] Routing example updates (CanReuse) + some minor toh field renaming (#1435)

* Router example: add CanReuse + some cleanup

* Examples(toh-*): field rename

* Router field rename

* Router example: use InstanceLogger

[5-dev] Router guide overview cleanup; show all guide pages (#1439)

[5-dev] Upgrade SDK to 2-dev.43 (#1441)

[5-dev] Enable use of angular_analyzer_plugin + minor tutorial refactorings (#1442)

* toh-1, toh-2

* toh-3

* toh-4

* toh-5

* toh-6

* Router updates

* Updates to all other example analysis_options.yaml files

(Add back `strong-mode: true`)

* toh-2 prose tweak

[5-dev] Enable router page link checks; fix link anchors (#1443)

[5-dev] Upgrade ACX, Angular 5-alpha+8 (#1446)

[5-dev] Fix pipes example (#1447)

[5-dev] toh-2: fix code excerpt so it includes click event binding (#1449)

Fixes #1448

Change build_runner links to point to pub (#1453)

...instead of the README in the repo.

[5-dev] Upgrade SDK to 2-dev.44 (#1454)

[5-dev] #1443, #1455

[5-dev] Adjust pages referring to build_runner (#1463)

Fixes #1450
(actually, it completes the fix)

[5-dev] Router: describe CanNavigate hook (#1465)

[5-dev] Examples: upgrade min package version for build_runner, build_web_compilers (#1470)

* Updated pubspec.yaml files

* Updated pubspec.lock files

* Refresh code excerpts

chalin added a commit that referenced this issue Apr 10, 2018

[5-dev] Angular 5-alpha+8, SDK 2-dev.46
#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

[5-dev] Upgrade SDK to 2-dev.42 (#1428)

Updated pubspec.lock files

[5-dev] Router example: fix crisis selection and other misc fixes (#1430)

[5-dev] Remove "Dartium", "content shell", and pub transformers (#1429)

* [5-dev] Remove "Dartium" and "content shell"

* Drop Dartium page and logo; setup firebase redirect

* Drop pub and transformer pages; redirect to dart-2

* Post-review edits

[5-dev] Routing example updates (CanReuse) + some minor toh field renaming (#1435)

* Router example: add CanReuse + some cleanup

* Examples(toh-*): field rename

* Router field rename

* Router example: use InstanceLogger

[5-dev] Router guide overview cleanup; show all guide pages (#1439)

[5-dev] Upgrade SDK to 2-dev.43 (#1441)

[5-dev] Enable use of angular_analyzer_plugin + minor tutorial refactorings (#1442)

[5-dev] Enable router page link checks; fix link anchors (#1443)

[5-dev] Upgrade ACX, Angular 5-alpha+8 (#1446)

[5-dev] Fix pipes example (#1447)

[5-dev] toh-2: fix code excerpt so it includes click event binding (#1449)

Change build_runner links to point to pub (#1453)

[5-dev] Upgrade SDK to 2-dev.44 (#1454)

[5-dev] #1443, #1455

[5-dev] Adjust pages referring to build_runner (#1463)

[5-dev] Router: describe CanNavigate hook (#1465)

[5-dev] Examples: upgrade min package version for build_runner, build_web_compilers (#1470)

chalin added a commit that referenced this issue Apr 10, 2018

Merge 5-dev into master (#1476)
* [5-dev] temporary changes to config files, etc (#1129, #1131)

Temporary changes: suspend some checks, etc.

- Build using dev SDK
- Mark guide/router page as DRAFT
- Skip api links to 1.x router entries

* [5-dev] Angular 5-alpha+8, SDK 2-dev.46

#1130, #1139, #1193

* [5-dev] Updated angular versions

* Examples: update pubspecs

* Refresh code excerpts

* gulp/pkg-vers check: don't fail because angular_ast isn't the most recent

* chore(gulp/dartdoc): patch angular_* pkg pubspec before running dartdoc

[5-dev] toh-5/6 updates + skip some tests (#1143)

[5-dev] Pubspec updates, ACX 0.9.0-alpha+1

#1204, #1205, #1206, #1208, #1209, #1212

* Reinstate toh-5/6 E2E

* gulp/update-ng-vers adjustments

* Example pubspec: update SDK constraints

* Example pubspec: remove current dependency_overrides

* Example pubspec: update angular pkg versions

* Example pubspec: add required dependency_overrides

* Skip template-syntax component test

[5-dev] Example(toh-5): re-enable component tests (#1205)

Drop deep-linking test for link that isn't valid, since we don't deal with route wildcards in toh-5. That feature will be tested in the router example app.

This commit also includes a refresh of the code excerpts.

Followup to #1147
Contributes to #1058

Examples(toh-6): component test fix, re-enable tests (#1206)

Tests originally written under router 2.0 for ng 4.0 were failing here because they expected whitespace in templates (whitespace is no longer preserved by default). Tests have been adjusted.

Contributes to #1058

[5-dev] ACX 0.9.0-alpha+1, pubspec updates (#1208, #1209, #1212)

[5-dev] chore: example pubspec.lock files (#1209)

Start committing `pubspec.lock` files again under `5-dev`.

Contributes to #1195

[5-dev] Re-enable tests (#1210, #1212)

[5-dev] Re-enable template-syntax component tests (#1212)

They seem to be running fine now. It would seem that dart-lang/angular_components#198 is indeed intermittent.

[5-dev] chore: re-enable ddc tests (#1210)

[5-dev] Upgrade to 5.0.0-alpha+2 (#1243)

* pkg-vers.json update to match ng 5.0.0-alpha+2

* pubspec updates

* example change to template syntax

* Update examples/**/analysis_options.yaml

* Quickstart changes

* toh-0 changes

* toh-1 changes

* toh-2 changes

* toh-3 changes

* toh-4 changes

* toh-5 changes

* toh-6 changes

* examples updated pubspec.lock files

* example pubspec.yaml: fix ng to 5.0.0-alpha+2

* Initial updates for ng_test/github_issues

examples/ng_test/github_issues:
- pub upgrade runs fine
- pub serve does not

* lottery changes

* examples/ng/doc/[a-p]* changes

* example/ng/api updates

Both examples are running.

* examples/ng/doc remaining examples

* gulp/update-ng-vers.js update script

* A few trivial code-excerpt updates

* Adjust Travis jobs

[5-dev] re-enable component-style E2E

Squashed updates

Update to ACX 0.9.0-alpha+3 (#1278)

* pubspec.yaml: drop ACX dependency overrides

* pubspec.lock file updates

chore(E2E): redistribute E2E across Travis jobs (#1280)

[5-dev] Upgrade to 5.0.0-alpha+4, w/ ACX from git branch + overrides (#1275)

* pubspec.yaml file updates

* pkg-vers.json update

* For use of latest Angular even if ACX hasn't caught up

* puspec.lock file updates

* More angular_* package version updates

* angular_router overrides necessary because of ACX

[5-dev] Ensure component test failures are detected (#1273)

A workaround for dart-lang/build#874

[5-dev] switch to use of build_runner (#1272)

* Switch to using headless chrome for e2e and component test

* Drop aot tag from component test files

* examples/**/pubspec.yaml: add build_* and drop transformers

* Updated pubspeck.lock files

* Drop temporary sass_builder dep_override

* SDK at dev.19

* Refreshed pubspec.lock files

[5-dev] drop content-shell, use headless chrome (#1267)

Only minmal edits have been done to the prose to remove references to Dartium.  The rest will be handled as we clean out the dart-2.0 / dartium-2.0 tags.

[5-dev] Update to 5.0.0-alpha+3, w/o yet dropping content-shell (#1266)

* src/_data/pubspec.yaml

* examples/**/pubspec.yaml: upgrade to ng alpha+3

* lock files

* Temp: ACX overrides

* pkg-vers update

* gulp/update-ng-vers.js

* Travis(ng-pkg-pub-get): don't skip angular_ast

* Travis/scripts: also run component tests under dartdevc

Drop dart_test.yaml customization, use test's support for headless chrome (#1283)

Fixes #1282

* pubspec upgrades

* pubspec.yaml: use test 0.12.30

[5-dev] reinstate dart2js-based testing (#1285)

Fixes #1284

Component tests are run under dartdevc only (for those that _are_ running, which is only two at the moment). All active E2E tests are run under both compilers (pending example migration to Angular 5 and bugs in dart2js).

[5-dev] feat: switch to new template parser (#1289)

* [5-dev] feat: switch to new template parser

Fixes #1281

* Bugs identified by the new template compiler!

* Skip template-sytax E2E due to issue with TemplateGenerator

[5-dev] Upgrade build_* packages to get latest fixes (#1290)

* [5-dev] Upgrade build_* packages to get latest fixes

* Skip toh-0 component tests due to issue

[5-dev] Re-enable template-syntax e2e under dartdevc (#1294)

[5-dev] chore(tests): use --checked option when using dart2js (#1296)

[5-dev] chore(tests): fail if build contains WARNING or SEVERE (#1295)

* [5-dev] chore(tests): fail if build contains WARNING or SEVERE

* Report errors before missing ok regex match

* Refine check of exit code

[5-dev] Changelog update, and added build_* pkg version freshness check (#1299)

[5-dev] drop the `browser` package from examples (#1301)

* Drop browser package from pubspec.yaml

* Update web/index.html

* update script tweaks

* Updated pubspec.lock files

* Add changelog entry

* Post review updates

[5-dev] Upgrade to SDK 2-dev.20 (#1302)

[5-dev] Minor additions to changelog entry for Angular test files (#1305

 [5-dev] re-instate toh-0 component tests and update pubspec.lock files (#1308)

* [5-dev] re-instate toh-0 component tests

* Updated pubspec.lock files

[5-dev] Update to Angular 5-alpha+5, except for examples using ACX (#1310)

* [5-dev] Update to Angular 5-alpha+5, except for examples using ACX

- Drop analyzer dependency override

* Skip dartdoc due to pkg mismatch issues; skip structural-directives e2e

[5-dev] Updated Angular app Setup instructions (CLI + WebStorm note) (#1307)

* [5-dev] Updated instructions for setting up Angular apps

- CLI instructions are complete.
- Added note to say that WebStorm support isn't yet available.
- Simplified WebStorm tooling page, which should not have details about how to launch apps -- that is what the setup page is for.

* Post-review edits

[5-dev] Upgrade to ACX alpha+4 (#1312)

[5-dev] template-syntax: drop use of deprecated QueryList (#1313)

(Also re-enable structural-directives e2e.)

[5-dev] Upgrade to SDK 2-dev.23 (#1318)

[5-dev] chore(travis): fix env var init (#1319)

[5-dev] Re-enable dart2js template-syntax E2E (#1321)

Given that dart-lang/sdk#31889 has been fixed.

[5-dev] Use cmd line option vs. dynamically generated build.yaml file (#1322)

Also
- Dropped `--no-precompile`
- Added individual example .dart_tool folders

[5-dev] Temporarily disable tests for ACX examples (#1320)

Due to dart-lang/angular_components#219

[5-dev] Use Travis stages (#1324)

- Builds used to last >20 min, for a total time of 2.5 hours; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/339555931).
- Once caches are updated, the current build requires <20 min for a total time of <50 min; e.g. see [this Travis log](https://travis-ci.org/dart-lang/site-webdev/builds/341190078).

Almost all of the benefits are from improved caching, not stages. There is room for further improvements, but this will do for now, while we move on to other work items.

(For some reason fonts are not being generated in woff2 format. Temporarily added rule to link check skip list.)

[5-dev] Upgrade SDK and ACX; re-enable all e2e and API doc gen (#1323)

* Upgrade SDK to 2-dev.24
* Upgrade ACX to 0.9.0-alpha+5
* Updated pubspec.lock files
* Re-enable e2e structural-directives, template-syntax
* Enable API doc generation
* bump up cache timeout to 5 min

[5-dev] Upgrade SDK to 2-dev.26 (#1333)

* chore: don't fail because asset graph is discarded

[5-dev] Upgrade SDK to 2-dev.28 (#1335)

[5-dev] Upgrade to SDK 2-dev.30 (#1339)

[5-dev] Upgrade to 5.0.0-alpha+6 (#1342)

* [5-dev][WIP] Upgrade to 5.0.0-alpha+6

WIP: partial update as we await ACX release.

* Upgrade to latest ACX

* CORE_DIRECTIVES --> coreDirectives

* Changelog update

[5-dev] Upgrade to SDK 2-dev.31 (#1347)

[5-dev] Using mock pageloader and re-enable all comp tests (#1350)

Fixes #1277 by making use of a mock pageloader + manually added PO field binding code.

Due to some tests hanging under headlesss chrome (dart-lang/test#772), we're re-instating script/browser.sh

[5-dev][Temp] Don't compile selected component test files (#1343)

Selected E2E tests are currently failing because the web compilers are trying to compile component tests that use pageloader, which we cannot currently use -- see #1277.

This should get all Travis jobs to pass.

[5-dev] Refresh of selected code excerpts (#1354)

Add WebStorm angular 5 support warning to Get Started page

[5-dev] Upgrade to Dart 2-dev.32 (#1361)

[5-dev] DI page: update bootstrapStatic description (#1355)

* [5-dev] DI page: update bootstrapStatic description

* Add note

[5-dev] toh-0 pubspec.yaml description: drop transformer and browser (#1367)

[5-dev] Clarify site status and link to tracking issue (#1370)

[5-dev] Pubspec updates, in particular to use mock pageloader (#1371)

* [5-dev] Pubspec updates, in particular to use mock pageloader

* Tweak pageloader mock description

* E2E and Test: don't fail if the asset graph is invalidated

[5-dev] Updated component testing examples and docs (#1375)

* Misc code excerpt changes

* [5-dev] Updated component testing examples and docs

[5-dev] pubspec(examples/util/pageloader) update

[5-dev] Upgrade to Angular alpha+7 (#1381)

* [5-dev] Upgrade to Angular alpha+7

Also set Min SDK is dev.28

* More pubspec.lock updates

* Adjust to new builder output format

* Code excerpt updates because of pubspec changes

* Temporarily disable component tests

... until #1382 is fixed

[5-dev] More pubspec.lock updates

[5-dev] Upgrade ACX to alpha+7 (#1386)

[5-dev] Upgrade ACX to alpha+7, SDK dev.33 and reinstate component tests

[5-dev] Upgrade SDK to dev.35 (#1387)

[5-dev] pubspec.lock update for mock examples/util/pageloader

[5-dev] Replace router guide by warning that it is being updated (#1389)

Contributes to #1388

[5-dev] Toh-5: require angular_router import earlier (#1390)

Fixes #1388

[5-dev] Examples: fix analyzer warnings on ElementRef, JSON, Router.stream (#1391)

* [5-dev] Examples: fix analyzer warnings

- `ElementRef` --> `Element` (second wave of changes)
- `JSON` --> `json`
- `Router.stream` --> `Router.onRouteActivated`

* Remaining puspec.lock updates

[5-dev] Pubspec updates (#1395)

[5-dev] Drop examples/ng_test/github_issues since it has moved (#1404)

Fixes #1372

The example was moved to dart-lang/angular/examples via dart-lang/angular@9270d97

This examples was not referenced in any of the documentation.

[5-dev] Upgrade to SDK 2-dev.38 (#1405)

[5-dev] Adjust Dart 2 migration page variables (#1406)

[5-dev] pubspec updates (#1407)

* pubspec.yaml cleanup: drop `+\d` from angular pkg version

* Code excerpt refresh

* pubspec.lock file updates

[5-dev] toh-5 app tweak; router page updates (none visiable); check code freshness (#1408)

* misc router guide adjustments (non are visible)

* toh-5: app_routes.dart tweak

* Re-enable refresh-code-excerpts.sh checks

[5-dev] pub build/serve --> build_runner (#1409)

* [5-dev] pub build/serve --> build_runner

Main changes:

- Added a `build_runner` page.
- Updated the Tools landing page.
- The pages for the following tools have been replaced by a note that says that the are deprecated/no longer supported: dartium, pub, pub build, pub serve.
- dartdevc page updates

---

Contributes to #1366
Fixes #1393
Supersedes #1397

* Post-review edits

* gulpefile.js fix: this ran fin before, I'm uncertain what changed

* Remove obsolete link

[5-dev] Upgrade to Angualr 5-alpha+8 (#1411)

[5-dev] Updates to router guide example up to Milestone 3 (#1412)

* Initial tweaks

* router/1.md updates

* Ensure check-for-numbered-files-in-html.sh passes and fix appendix excerpts

* Milestone 2

* Fix toh-5 code excerpt formatting

* Milestone 3

x

[5-dev][Temporary] Patch angular_forms pubspec so we can build API docs (#1413)

[5-dev] SDK 2-dev.40: updated pubspec.lock files (#1415)

[5-dev] Example cleanup as part of Dart 2 prep (#1416)

* [5-dev] Example cleanup as part of Dart 2 prep

Dart 2 related:

- Replaced `Future<Null>` by `Future<void>`
- Dropped `const` literal qualifier where possible

Cleanup of Toh et all:

- Use `const ClassProvider()`, etc.
- HeroService: renamed `getHeroes()` to `getAll()`
- HeroService: renamed `getHero()` to `get()`

Contributes to #1366

* Use const ClassProvider

* Skip hierarchical di E2E

dart-lang/angular#1102

[5-dev] Simplifying Router example (refactoring) (#1417)

[5-dev] toh-5: use RESTful routes, and app_route_paths.dart file (#1419)

Contributes to #1058, #1369

- Reworking toh-5 so that it is a better base for the router guide.
- All toh:
  - Switched to using ClassProvider()
  - Renamed hero_detail* to hero*

[5-dev] Examples toh and router refactoring (#1421)

Builds on #1419
Contributes to #1058

Renames:
- heroes_* &rarr; hero_list_*
- crises_* &rarr; crisis_list_*

[5-dev] Router guide work on milestone 4, include ToH updates (#1423)

* Revert back to "Crisis Center" feature name

* toh-5/router: simplify router path definitions

toh-5 tests pass

* toh-5: don't use useAsDefault

* Misc cleanup

* toh-6: updated routes to match toh-5

* router: inline redirect and wildcard routes

* Final edits for Milestone 3

* toh, router refactoring: drop `app_` file name prefix on route files

toh-5/6 tests pass

* toh, router: renamed AppRoutes to Routes

* Trail using CrisisCenterComponent

* Some initial M4 work

[5-dev] Router guide, milestone 4; re-enable router E2E (#1424)

Contributes to #1058

[5-dev] Code cleanup following fix to `@ViewChildren()` (#1425)

Code cleanup now that dart-lang/angular#814 has been fixed.

[5-dev] Router, initial milestone 5 work (#1427)

* Leon confirmed that there is no support for named outlets

* [5-dev] Router, initial M5 work

* Router M5: Temporary, for debugging purposes

[5-dev] replace all `pub build/serve` by `build_runner build/serve` (#1426)

* [5-dev] replace all `pub build/serve` by `build_runner build/serve`

Fixes #1392, #1398

* Fix anchors; include part of "remove temp files"

* A first round of post-review edits

* Another post-review edit

* More edits

* Update issue number

* Final adjustments

[5-dev] Upgrade SDK to 2-dev.42 (#1428)

Updated pubspec.lock files

[5-dev] Router example: fix crisis selection and other misc fixes (#1430)

[5-dev] Remove "Dartium", "content shell", and pub transformers (#1429)

* [5-dev] Remove "Dartium" and "content shell"

* Drop Dartium page and logo; setup firebase redirect

* Drop pub and transformer pages; redirect to dart-2

* Post-review edits

[5-dev] Routing example updates (CanReuse) + some minor toh field renaming (#1435)

* Router example: add CanReuse + some cleanup

* Examples(toh-*): field rename

* Router field rename

* Router example: use InstanceLogger

[5-dev] Router guide overview cleanup; show all guide pages (#1439)

[5-dev] Upgrade SDK to 2-dev.43 (#1441)

[5-dev] Enable use of angular_analyzer_plugin + minor tutorial refactorings (#1442)

[5-dev] Enable router page link checks; fix link anchors (#1443)

[5-dev] Upgrade ACX, Angular 5-alpha+8 (#1446)

[5-dev] Fix pipes example (#1447)

[5-dev] toh-2: fix code excerpt so it includes click event binding (#1449)

Change build_runner links to point to pub (#1453)

[5-dev] Upgrade SDK to 2-dev.44 (#1454)

[5-dev] #1443, #1455

[5-dev] Adjust pages referring to build_runner (#1463)

[5-dev] Router: describe CanNavigate hook (#1465)

[5-dev] Examples: upgrade min package version for build_runner, build_web_compilers (#1470)

* [5-dev] Add SDK install pages via shared git submodule (#1472)

Fixes #637
Fixes #1471

* Config changes before merging 5-dev into master (#1475)

Contributes to #1474

@chalin chalin referenced this issue Apr 12, 2018

Closed

2018Q2 work log #1484

56 of 82 tasks complete

chalin added a commit that referenced this issue May 8, 2018

chalin added a commit that referenced this issue May 10, 2018

chalin added a commit that referenced this issue May 11, 2018

Update WebStorm screenshots, warn min version (#1582)
* Update WebStorm screenshots, warn min version

Contributes to #1369

* Post-review edits

* Post-review edits

* Don't rely on runtimeType in DI E2E

Make the DI app behave the same whether it is the dev or production version. (In the production version of the app, minification changes type names. Actually, compilation to JS can result in a change in type name, but that is beside the point.)

* Build using --no-release for testing purposes

* Post-review edits

@chalin chalin referenced this issue Jun 19, 2018

Closed

Examples: Drop `new` and unnecessary `const` #1650

5 of 5 tasks complete

@chalin chalin removed this from the ng5-dev_18Q2 milestone Jul 3, 2018

@chalin chalin added this to the ng5-dev_18Q3 milestone Jul 3, 2018

@chalin chalin modified the milestones: ng5_18Q3, ng5_18Q4 Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment