New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edit: angular/guide/setup #1199

Merged
merged 3 commits into from Dec 6, 2017

Conversation

Projects
None yet
5 participants
@jenapp
Contributor

jenapp commented Nov 24, 2017

Edits mainly to do with lists and procedures

Copy edit: angular/guide/setup
Edits mainly to do with lists and procedures

@googlebot googlebot added the cla: yes label Nov 24, 2017

@sarahmaddox

Thanks, this looks great! Just one small change, then LGTM (that stands for "looks good to me", a common abbreviation in code reviews).

[downloading them]({{site.ghNgEx}}/quickstart/archive/{{site.branch}}.zip)
or cloning the repo.
You can get the project's files by the following methods:
* [Downloading them.]({{site.ghNgEx}}/quickstart/archive/{{site.branch}}.zip)

This comment has been minimized.

@sarahmaddox

sarahmaddox Nov 24, 2017

Contributor

The full stop should go outside the bracket, otherwise the link underlining will extend to the full stop.

Downloading them.

@sarahmaddox

sarahmaddox Nov 24, 2017

Contributor

The full stop should go outside the bracket, otherwise the link underlining will extend to the full stop.

Downloading them.

This comment has been minimized.

@chalin

chalin Nov 24, 2017

Collaborator

Actually, the original change was correct. This is because links to external sources (like this one) have a redirect arrow displayed after them. So it is better to have punctuation as part of the link.

Here is an example from another page (actual links not shown):

### More information

... Also see the API docs for[dart:mirror,][dart:mirror] 
especially [MirrorsUsed,](https://...)
[ClassMirror,](...) and [InstanceMirror.](...)

This excerpt is rendered as

screen shot 2017-11-23 at 20 35 26

@chalin

chalin Nov 24, 2017

Collaborator

Actually, the original change was correct. This is because links to external sources (like this one) have a redirect arrow displayed after them. So it is better to have punctuation as part of the link.

Here is an example from another page (actual links not shown):

### More information

... Also see the API docs for[dart:mirror,][dart:mirror] 
especially [MirrorsUsed,](https://...)
[ClassMirror,](...) and [InstanceMirror.](...)

This excerpt is rendered as

screen shot 2017-11-23 at 20 35 26

@sarahmaddox

Thanks! LGTM.

@chalin

This comment has been minimized.

Show comment
Hide comment
@chalin

chalin Nov 24, 2017

Collaborator

Thanks for the edits! I'll let @kwalrath make a final review before merging.

Collaborator

chalin commented Nov 24, 2017

Thanks for the edits! I'll let @kwalrath make a final review before merging.

@chalin chalin requested a review from kwalrath Nov 24, 2017

@kwalrath

Nice edits. Thanks, @jenapp!

@kwalrath kwalrath merged commit 2ca30aa into dart-lang:master Dec 6, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kwalrath

This comment has been minimized.

Show comment
Hide comment
@kwalrath

kwalrath Dec 6, 2017

Member

Contributes to #1183.

Member

kwalrath commented Dec 6, 2017

Contributes to #1183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment