Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Native Extensions article #980

Closed
chalin opened this issue Jun 29, 2018 · 5 comments
Closed

Update Native Extensions article #980

chalin opened this issue Jun 29, 2018 · 5 comments
Labels
a.articles Relates to articles written on topics in Dart e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@chalin
Copy link
Contributor

chalin commented Jun 29, 2018

Followup to #973 (comment) for the Native Extensions article.

  • Use <?code-excerpts?>
  • Update to Dart 2.
@chalin chalin mentioned this issue Jun 29, 2018
Closed
20 tasks
@chalin
Copy link
Contributor Author

chalin commented Jun 29, 2018

@a-siva: is there a way to invoke ./tools/test.py to just run the samples/sample_extension tests? /cc @kwalrath

@chalin
Copy link
Contributor Author

chalin commented Jun 29, 2018

@a-siva: nm, I was able to build the extension and run the tests.

chalin added a commit to chalin/sdk that referenced this issue Jun 29, 2018
@chalin
Update 'samples/sample_extension' to Dart 2
bbabf29 
- Ran dartfmt --fix
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to dart-lang/site-www#980
@chalin chalin mentioned this issue Jun 29, 2018
Closed
@a-siva
Copy link

a-siva commented Jun 29, 2018

sivalinuxmach[sdk]>tools/test.py -cdartk samples
Test configuration: dartk_vm_debug_x64
[00:04 | 100% | + 5 | - 0]
sivalinuxmach[sdk]>

Should do it.

chalin added a commit to chalin/sdk that referenced this issue Jun 29, 2018
@chalin
Update 'samples/sample_extension' to Dart 2
c2d85a7 
- Ran dartfmt --fix
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to dart-lang/site-www#980
chalin added a commit to chalin/sdk that referenced this issue Dec 7, 2018
@chalin
Update 'samples/sample_extension' to Dart 2
22585cb 
- Ran dartfmt --fix
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to dart-lang/site-www#980
chalin added a commit to chalin/sdk that referenced this issue Dec 7, 2018
@chalin
Update 'samples/sample_extension' to Dart 2
4c8b9d8 
- Ran dartfmt --fix
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to dart-lang/site-www#980
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Dec 9, 2018
@chalin
Update 'samples/sample_extension' to Dart 2
fba5a58 
- Ran `dartfmt --fix`
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to dart-lang/site-www#980

cc @a-siva @kwalrath @kevmoo

Closes #33711
#33711

GitOrigin-RevId: a832220
Change-Id: Ia542ce073d2f9a4c78934a74ee17b60156a49d25
Reviewed-on: https://dart-review.googlesource.com/c/63260
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
@kwalrath
Copy link
Contributor

#1294 fixed a link, but this article could still use a closer look and more integration/updating of its example code.

@kwalrath kwalrath added p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e2-days Can complete in < 5 days of normal, not dedicated, work a.articles Relates to articles written on topics in Dart labels Jan 31, 2019
@chalin chalin mentioned this issue Aug 3, 2019
Closed
23 tasks
@parlough
Copy link
Member

Now that support for this mechanism was removed and this documentation only points elsewhere, there is nothing to left to update, so closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a.articles Relates to articles written on topics in Dart e2-days Can complete in < 5 days of normal, not dedicated, work p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwalrath @chalin @a-siva @parlough