Start adding LibraryReader.prefixForType. #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Jan 12, 2018
lib/src/library.dart
Outdated
| /// const b = const bar.Bar(); | ||
| /// ``` | ||
| /// | ||
| /// ... we'd assume that `b`'s element has a prefix of `bar`. |
There was a problem hiding this comment.
I'm still confused by this. There isn't anywhere we'd have the code bar.b - so why is it that b is considered to have a prefix?
There was a problem hiding this comment.
Yeah this isn't an accurate example anymore. I'll update it.
natebosch
reviewed
Jan 12, 2018
test/library_reader_test.dart
Outdated
| }); | ||
|
|
||
| test('should read the prefix of a type', () { | ||
| expect(testingPrefixForType(b, topLevelFieldTypes[0]), 'a_prefixed'); |
There was a problem hiding this comment.
Can we look for specific variables rather than rely on the ordering?
natebosch
approved these changes
Jan 12, 2018
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
* Start adding LibraryReader.prefixForType. * Update docs. * More stable testing.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
* Start adding LibraryReader.prefixForType. * Update docs. * More stable testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #292.
I've made the feature package-private so we can iterate. It's possible we won't even be able to launch this as-is (if
computeNode()explodes), but at least we will have the test case(s) when we have a replacement API, so I think it's worth checking (most) of this in.