Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless for Chrome when enabling coverage #1171

Open
cedx opened this issue Feb 5, 2020 · 1 comment · May be fixed by #1172
Open

Headless for Chrome when enabling coverage #1171

cedx opened this issue Feb 5, 2020 · 1 comment · May be fixed by #1172

Comments

@cedx
Copy link

@cedx cedx commented Feb 5, 2020

When I run browser tests without enabling coverage, Chrome runs in headless mode.
But when I enable coverage, Chrome seems to run in GUI mode: this breaks tests in CI environments (GitHub Actions, Travis CI, ...) where we don't have a GUI.

@grouma

This comment has been minimized.

Copy link
Member

@grouma grouma commented Feb 5, 2020

Coverage runs imply debug mode. We have this conditional which ties it to the headless feature:

if (!debug && settings.headless) {

Since we can explicitly configure the headless feature I don't see any concern in updating that conditional. I'll happily review a PR.

cedx added a commit to cedx/test that referenced this issue Feb 5, 2020
@cedx cedx linked a pull request that will close this issue Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.