Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 06cf6268b35a426e326079a1a829df3839b43038. #121

Merged
merged 1 commit into from May 21, 2015
Merged

Conversation

nex3
Copy link
Member

@nex3 nex3 commented May 21, 2015

Some tests, especially those using HTML imports, aren't ready to be run
when readyState is set to "complete".

Review on Reviewable

@kevmoo
Copy link
Member

kevmoo commented May 21, 2015

Make it a release?

Some tests, especially those using HTML imports, aren't ready to be run
when readyState is set to "complete".
@nex3
Copy link
Member Author

nex3 commented May 21, 2015

Done.


Review status: 0 of 3 files reviewed, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@kevmoo
Copy link
Member

kevmoo commented May 21, 2015

LGTM (:metal:) but change the commit description to explain

with a body that includes the commit SHA so GitHub magic linking works

nex3 added a commit that referenced this pull request May 21, 2015
@nex3 nex3 merged commit 298ab0e into 0.11.x May 21, 2015
@nex3 nex3 deleted the undo-ready-state branch May 21, 2015 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants