Add Target annotations to annotation classes #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the analyzer to emit diagnostics when the annotations are used in places where they will not be honored by the test runner. When used as annotations (as opposed to arguments to `test` or `group`) the test runner only looks at the library level and all annotations apply to an entire test suite.
|
Does this still allow annotations on the first directive in the file? That is actually what is supported by the test package. |
Yes it does. https://pub.dev/documentation/meta/latest/meta_meta/TargetKind-class.html
|
natebosch
added a commit
that referenced
this pull request
May 23, 2022
Closes dart-lang/sdk#49071 Add a `Target` with the `TargetKind.library` so that the analyzer understands that the annotation is logically applied to the library, even when it is syntactically applied on an import. This fixes behavior when sorting imports. The same configuration was applied to other imports in #1345 and this looks like it was an accidental omission.
This was referenced May 23, 2022
natebosch
added a commit
that referenced
this pull request
May 24, 2022
Closes dart-lang/sdk#49071 Add a `Target` with the `TargetKind.library` so that the analyzer understands that the annotation is logically applied to the library, even when it is syntactically applied on an import. This fixes behavior when sorting imports. The same configuration was applied to other imports in #1345 and this looks like it was an accidental omission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the analyzer to emit diagnostics when the annotations
are used in places where they will not be honored by the test runner.
When used as annotations (as opposed to arguments to
testorgroup)the test runner only looks at the library level and all annotations
apply to an entire test suite.