From 22ae40a7c27a6254d37822f79c3f4f2b532d631f Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Tue, 31 Jan 2023 00:13:24 +0000 Subject: [PATCH 1/2] Annotate `checkThat` with `usResult` It would never be useful to set up a `Subject` and not check any expectations on it. --- pkgs/checks/lib/src/checks.dart | 2 ++ pkgs/checks/pubspec.yaml | 1 + 2 files changed, 3 insertions(+) diff --git a/pkgs/checks/lib/src/checks.dart b/pkgs/checks/lib/src/checks.dart index 7b8bc8c81..818cc0274 100644 --- a/pkgs/checks/lib/src/checks.dart +++ b/pkgs/checks/lib/src/checks.dart @@ -5,6 +5,7 @@ // TODO Add doc about how failure strings work. import 'dart:async'; +import 'package:meta/meta.dart'; import 'package:test_api/hooks.dart'; import 'describe.dart'; @@ -58,6 +59,7 @@ extension Skip on Subject { /// ```dart /// checkThat(actual).equals(expected); /// ``` +@useResult Subject checkThat(T value, {String? because}) => Subject._(_TestContext._root( value: _Present(value), diff --git a/pkgs/checks/pubspec.yaml b/pkgs/checks/pubspec.yaml index a2b6fbc49..77027732a 100644 --- a/pkgs/checks/pubspec.yaml +++ b/pkgs/checks/pubspec.yaml @@ -10,6 +10,7 @@ environment: dependencies: async: ^2.8.0 + meta: ^1.9.0 test_api: ^0.4.0 dev_dependencies: From 863b75634f631db7504e053213de94e056b203be Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Tue, 31 Jan 2023 05:30:04 +0000 Subject: [PATCH 2/2] add import prefix --- pkgs/checks/lib/src/checks.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/checks/lib/src/checks.dart b/pkgs/checks/lib/src/checks.dart index 818cc0274..3a43fd177 100644 --- a/pkgs/checks/lib/src/checks.dart +++ b/pkgs/checks/lib/src/checks.dart @@ -5,7 +5,7 @@ // TODO Add doc about how failure strings work. import 'dart:async'; -import 'package:meta/meta.dart'; +import 'package:meta/meta.dart' as meta; import 'package:test_api/hooks.dart'; import 'describe.dart'; @@ -59,7 +59,7 @@ extension Skip on Subject { /// ```dart /// checkThat(actual).equals(expected); /// ``` -@useResult +@meta.useResult Subject checkThat(T value, {String? because}) => Subject._(_TestContext._root( value: _Present(value),